Version Bump v11.3.0

Feature: Recipe prices are now calculated based on periods and saved
Feature: The recipe export excel now has prices

brewman/alembic/versions/12262aadbc08_recipe_templates.py

@@ -5,41 +5,46 @@ Revises: a1372ed99c45
 Create Date: 2023-04-14 07:50:22.110724
 
 """
-from alembic import op
 import sqlalchemy as sa
 
+from alembic import op
+
+
 # revision identifiers, used by Alembic.
-revision = '12262aadbc08'
-down_revision = 'a1372ed99c45'
+revision = "12262aadbc08"
+down_revision = "a1372ed99c45"
 branch_labels = None
 depends_on = None
 
 
 def upgrade():
     # ### commands auto generated by Alembic - please adjust! ###
-    op.create_table('recipe_templates',
-    sa.Column('id', sa.Uuid(), nullable=False),
-    sa.Column('name', sa.Unicode(), nullable=False),
-    sa.Column('date', sa.Date(), nullable=False),
-    sa.Column('text', sa.Unicode(), nullable=False),
-    sa.Column('selected', sa.Boolean(), nullable=False),
-    sa.PrimaryKeyConstraint('id', name=op.f('pk_recipe_templates')),
-    sa.UniqueConstraint('name', name=op.f('uq_recipe_templates_name'))
+    op.create_table(
+        "recipe_templates",
+        sa.Column("id", sa.Uuid(), nullable=False),
+        sa.Column("name", sa.Unicode(), nullable=False),
+        sa.Column("date", sa.Date(), nullable=False),
+        sa.Column("text", sa.Unicode(), nullable=False),
+        sa.Column("selected", sa.Boolean(), nullable=False),
+        sa.PrimaryKeyConstraint("id", name=op.f("pk_recipe_templates")),
+        sa.UniqueConstraint("name", name=op.f("uq_recipe_templates_name")),
     )
-    op.create_index('only_one_selected_template', 'recipe_templates', ['selected'], unique=True, postgresql_where=sa.text('selected = true'))
-    op.alter_column('recipes', 'notes',
-               existing_type=sa.VARCHAR(length=255),
-               type_=sa.Text(),
-               existing_nullable=False)
+    op.create_index(
+        "only_one_selected_template",
+        "recipe_templates",
+        ["selected"],
+        unique=True,
+        postgresql_where=sa.text("selected = true"),
+    )
+    op.alter_column("recipes", "notes", existing_type=sa.VARCHAR(length=255), type_=sa.Text(), existing_nullable=False)
     # ### end Alembic commands ###
 
 
 def downgrade():
     # ### commands auto generated by Alembic - please adjust! ###
-    op.alter_column('recipes', 'notes',
-               existing_type=sa.Text(),
-               type_=sa.VARCHAR(length=255),
-               existing_nullable=False)
-    op.drop_index('only_one_selected_template', table_name='recipe_templates', postgresql_where=sa.text('selected = true'))
-    op.drop_table('recipe_templates')
+    op.alter_column("recipes", "notes", existing_type=sa.Text(), type_=sa.VARCHAR(length=255), existing_nullable=False)
+    op.drop_index(
+        "only_one_selected_template", table_name="recipe_templates", postgresql_where=sa.text("selected = true")
+    )
+    op.drop_table("recipe_templates")
     # ### end Alembic commands ###

brewman/alembic/versions/48af31eb6f3f_fp.py

@@ -0,0 +1,23 @@
+"""Fingerprint Index
+
+Revision ID: 48af31eb6f3f
+Revises: 12262aadbc08
+Create Date: 2023-08-07 13:01:05.401492
+
+"""
+from alembic import op
+
+
+# revision identifiers, used by Alembic.
+revision = "48af31eb6f3f"
+down_revision = "12262aadbc08"
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    op.create_unique_constraint(op.f("uq_fingerprints_date"), "fingerprints", ["date", "employee_id"])
+
+
+def downgrade():
+    op.drop_constraint(op.f("uq_fingerprints_date"), "fingerprints", type_="unique")

brewman/alembic/versions/a1372ed99c45_recipe_upgrade.py

@@ -8,8 +8,9 @@ Create Date: 2023-03-31 05:03:40.408240
 import sqlalchemy as sa
 
 from alembic import op
-from sqlalchemy.dialects import postgresql
 from sqlalchemy import func
+from sqlalchemy.dialects import postgresql
+
 
 # revision identifiers, used by Alembic.
 revision = "a1372ed99c45"
@@ -62,15 +63,15 @@ def upgrade():
     op.add_column("recipes", sa.Column("garnishing", sa.Text(), nullable=False, server_default=""))
     op.add_column("recipes", sa.Column("plating", sa.Text(), nullable=False, server_default=""))
     op.drop_constraint(op.f("uq_recipes_sku_id"), "recipes", type_="unique")
-    op.alter_column("recipes", "notes", existing_type=sa.VARCHAR(length=255),type=sa.Text(), nullable=False)
-    op.create_unique_constraint(op.f('uq_recipes_sku_id'), 'recipes', ['sku_id', 'date'])
+    op.alter_column("recipes", "notes", existing_type=sa.VARCHAR(length=255), type=sa.Text(), nullable=False)
+    op.create_unique_constraint(op.f("uq_recipes_sku_id"), "recipes", ["sku_id", "date"])
     op.create_index(op.f("ix_recipes_date"), "recipes", ["date"], unique=False)
     op.drop_constraint("fk_recipes_period_id_periods", "recipes", type_="foreignkey")
     op.drop_column("recipes", "period_id")
-    op.drop_column('recipes', 'sale_price')
-    op.drop_column('recipes', 'cost_price')
-    op.add_column('recipe_items', sa.Column('description', sa.Text(), nullable=False, server_default=""))
-    op.drop_column('recipe_items', 'price')
+    op.drop_column("recipes", "sale_price")
+    op.drop_column("recipes", "cost_price")
+    op.add_column("recipe_items", sa.Column("description", sa.Text(), nullable=False, server_default=""))
+    op.drop_column("recipe_items", "price")
     op.alter_column("role_permissions", "permission_id", existing_type=sa.UUID(), nullable=False)
     op.alter_column("role_permissions", "role_id", existing_type=sa.UUID(), nullable=False)
     op.create_unique_constraint(

brewman/alembic/versions/ba0fff092981_price.py

@@ -0,0 +1,39 @@
+"""price
+
+Revision ID: ba0fff092981
+Revises: 48af31eb6f3f
+Create Date: 2023-08-11 18:12:51.293741
+
+"""
+import sqlalchemy as sa
+
+from alembic import op
+
+
+# revision identifiers, used by Alembic.
+revision = "ba0fff092981"
+down_revision = "48af31eb6f3f"
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.create_table(
+        "prices",
+        sa.Column("id", sa.Uuid(), nullable=False),
+        sa.Column("period_id", sa.Uuid(), nullable=False),
+        sa.Column("product_id", sa.Uuid(), nullable=False),
+        sa.Column("price", sa.Numeric(precision=15, scale=2), nullable=False),
+        sa.ForeignKeyConstraint(["period_id"], ["periods.id"], name=op.f("fk_prices_period_id_periods")),
+        sa.ForeignKeyConstraint(["product_id"], ["products.id"], name=op.f("fk_prices_product_id_products")),
+        sa.PrimaryKeyConstraint("id", name=op.f("pk_prices")),
+        sa.UniqueConstraint("period_id", "product_id", name=op.f("uq_prices_period_id")),
+    )
+    # ### end Alembic commands ###
+
+
+def downgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.drop_table("prices")
+    # ### end Alembic commands ###

brewman/brewman/__main__.py

@@ -1,4 +1,4 @@
-from brewman.main import init
+from .main import init
 
 
 init()

brewman/brewman/__version__.py

@@ -1 +1 @@
-__version__ = "11.1.4"
+__version__ = "11.3.0"

brewman/brewman/db/base.py

@@ -19,6 +19,7 @@ from ..models.journal import Journal  # noqa: F401
 from ..models.login_history import LoginHistory  # noqa: F401
 from ..models.period import Period  # noqa: F401
 from ..models.permission import Permission  # noqa: F401
+from ..models.price import Price  # noqa: F401
 from ..models.product import Product  # noqa: F401
 from ..models.product_group import ProductGroup  # noqa: F401
 from ..models.rate_contract import RateContract  # noqa: F401

brewman/brewman/models/account.py

@@ -1,3 +1,5 @@
+import uuid
+
 from typing import TYPE_CHECKING
 
 from sqlalchemy.orm import Mapped, relationship
@@ -18,6 +20,30 @@ class Account(AccountBase):
         "Product", primaryjoin="Account.id==Product.account_id", back_populates="account"
     )
 
+    def __init__(
+        self,
+        name: str,
+        type_id: int,
+        is_starred: bool,
+        is_active: bool,
+        is_reconcilable: bool,
+        cost_centre_id: uuid.UUID,
+        code: int | None = None,
+        id_: uuid.UUID | None = None,
+        is_fixture: bool = False,
+    ) -> None:
+        if code is not None:
+            self.code = code
+        self.name = name
+        self.type_id = type_id
+        self.is_starred = is_starred
+        self.is_active = is_active
+        self.is_reconcilable = is_reconcilable
+        self.cost_centre_id = cost_centre_id
+        if id_ is not None:
+            self.id = id_
+        self.is_fixture = is_fixture
+
     def can_delete(self, advanced_delete: bool) -> tuple[bool, str]:
         if len(self.products) > 0:
             return False, "Account has products"

brewman/brewman/models/account_base.py

@@ -70,13 +70,6 @@ class AccountBase:
             self.id = id_
         self.is_fixture = is_fixture
 
-    def create(self, db: Session) -> "AccountBase":
-        self.code = db.execute(
-            select(func.coalesce(func.max(AccountBase.code), 0) + 1).where(AccountBase.type_id == self.type_id)
-        ).scalar_one()
-        db.add(self)
-        return self
-
     def can_delete(self, advanced_delete: bool) -> tuple[bool, str]:
         if self.is_fixture:
             return False, f"{self.name} is a fixture and cannot be edited or deleted."

brewman/brewman/models/fingerprint.py

@@ -3,7 +3,7 @@ import uuid
 from datetime import datetime
 from typing import TYPE_CHECKING
 
-from sqlalchemy import DateTime, ForeignKey, Uuid
+from sqlalchemy import DateTime, ForeignKey, UniqueConstraint, Uuid
 from sqlalchemy.orm import Mapped, mapped_column, relationship
 
 from ..db.base_class import reg
@@ -16,6 +16,7 @@ if TYPE_CHECKING:
 @reg.mapped_as_dataclass(unsafe_hash=True)
 class Fingerprint:
     __tablename__ = "fingerprints"
+    __table_args__ = (UniqueConstraint("date", "employee_id"),)
 
     id: Mapped[uuid.UUID] = mapped_column(Uuid, primary_key=True, insert_default=uuid.uuid4)
     employee_id: Mapped[uuid.UUID] = mapped_column(Uuid, ForeignKey("employees.id"), nullable=False)

brewman/brewman/models/price.py

@@ -0,0 +1,51 @@
+from __future__ import annotations
+
+import uuid
+
+from decimal import Decimal
+from typing import TYPE_CHECKING
+
+from sqlalchemy import ForeignKey, Numeric, UniqueConstraint, Uuid
+from sqlalchemy.orm import Mapped, mapped_column, relationship
+
+from ..db.base_class import reg
+
+
+if TYPE_CHECKING:
+    from .period import Period
+    from .product import Product
+
+
+@reg.mapped_as_dataclass(unsafe_hash=True)
+class Price:
+    __tablename__ = "prices"
+    __table_args__ = (UniqueConstraint("period_id", "product_id"),)
+
+    id: Mapped[uuid.UUID] = mapped_column(Uuid, primary_key=True, insert_default=uuid.uuid4)
+    period_id: Mapped[uuid.UUID] = mapped_column(Uuid, ForeignKey("periods.id"), nullable=False)
+    product_id: Mapped[uuid.UUID] = mapped_column(Uuid, ForeignKey("products.id"), nullable=False)
+    price: Mapped[Decimal] = mapped_column(Numeric(precision=15, scale=2), nullable=False)
+
+    period: Mapped["Period"] = relationship("Period")
+    product: Mapped["Product"] = relationship("Product")
+
+    def __init__(
+        self,
+        price: Decimal,
+        period_id: uuid.UUID | None = None,
+        product_id: uuid.UUID | None = None,
+        period: "Period" | None = None,
+        product: "Product" | None = None,
+        id_: uuid.UUID | None = None,
+    ):
+        self.price = price
+        if period_id is not None:
+            self.period_id = period_id
+        if product_id is not None:
+            self.product_id = product_id
+        if period is not None and (period.id is not None or period_id is None):
+            self.period = period
+        if product is not None and (product.id is not None or product_id is None):
+            self.product = product
+        if id_ is not None:
+            self.id = id_

brewman/brewman/models/recipe.py

@@ -40,3 +40,30 @@ class Recipe:
     tags: Mapped[list["Tag"]] = relationship(
         "Tag", secondary=RecipeTag.__table__, order_by="Tag.name", back_populates="recipes"
     )
+
+    def __init__(
+        self,
+        date_: date,
+        source: str,
+        instructions: str,
+        garnishing: str,
+        plating: str,
+        notes: str,
+        recipe_yield: Decimal,
+        sku_id: uuid.UUID | None = None,
+        sku: "StockKeepingUnit" | None = None,
+        id_: uuid.UUID | None = None,
+    ):
+        self.date_ = date_
+        self.source = source
+        self.instructions = instructions
+        self.garnishing = garnishing
+        self.plating = plating
+        self.notes = notes
+        self.recipe_yield = recipe_yield
+        if sku_id is not None:
+            self.sku_id = sku_id
+        if sku is not None:
+            self.sku = sku
+        if id_ is not None:
+            self.id = id_

brewman/brewman/models/recipe_item.py

@@ -29,3 +29,26 @@ class RecipeItem:
 
     recipe: Mapped["Recipe"] = relationship("Recipe", back_populates="items")
     product: Mapped["Product"] = relationship("Product")
+
+    def __init__(
+        self,
+        quantity: Decimal,
+        description: str = "",
+        recipe_id: uuid.UUID | None = None,
+        product_id: uuid.UUID | None = None,
+        recipe: "Recipe" | None = None,
+        product: "Product" | None = None,
+        id_: uuid.UUID | None = None,
+    ):
+        self.quantity = quantity
+        self.description = description
+        if recipe_id is not None:
+            self.recipe_id = recipe_id
+        if product_id is not None:
+            self.product_id = product_id
+        if recipe is not None:
+            self.recipe = recipe
+        if product is not None:
+            self.product = product
+        if id_ is not None:
+            self.id = id_

brewman/brewman/routers/account.py

@@ -35,15 +35,14 @@ def save(
         with SessionFuture() as db:
             item = Account(
                 name=data.name,
+                code=Account.get_code(data.type_, db),
                 type_id=data.type_,
                 is_starred=data.is_starred,
                 is_active=data.is_active,
                 is_reconcilable=data.is_reconcilable,
                 cost_centre_id=data.cost_centre.id_,
             )
-            item.code = db.execute(
-                select(func.coalesce(func.max(Account.code), 0) + 1).where(Account.type_id == item.type_id)
-            ).scalar_one()
+
             db.add(item)
             db.commit()
     except SQLAlchemyError as e:

brewman/brewman/routers/calculate_prices.py

@@ -0,0 +1,131 @@
+import uuid
+
+from decimal import Decimal
+
+from brewman.models.batch import Batch
+from brewman.models.cost_centre import CostCentre
+from brewman.models.inventory import Inventory
+from brewman.models.journal import Journal
+from brewman.models.period import Period
+from brewman.models.price import Price
+from brewman.models.voucher import Voucher
+from brewman.models.voucher_type import VoucherType
+from fastapi import HTTPException, status
+from sqlalchemy import distinct, func, select
+from sqlalchemy.dialects.postgresql import insert as pg_insert
+from sqlalchemy.exc import SQLAlchemyError
+from sqlalchemy.orm import Session
+
+from ..models.recipe import Recipe
+from ..models.recipe_item import RecipeItem
+from ..models.stock_keeping_unit import StockKeepingUnit
+
+
+def calculate_prices(period_id: uuid.UUID, db: Session):
+    try:
+        item: Period = db.execute(select(Period).where(Period.id == period_id)).scalar_one()
+        recipes = set(
+            db.execute(select(distinct(StockKeepingUnit.product_id)).join(StockKeepingUnit.recipes)).scalars().all()
+        )
+        ingredients = set(db.execute(select(distinct(RecipeItem.product_id))).scalars().all())
+        issued_products = get_issue_prices(item, ingredients - recipes, db)
+        left = ingredients - recipes - issued_products.keys()
+        purchased_products = get_issue_prices(item, left, db)
+        left -= purchased_products.keys()
+        rest = get_rest(left, db)
+        prices = issued_products | purchased_products | rest
+
+        while len(recipes) > 0:
+            calculate_recipes(recipes, prices, db)
+        for pid, price in prices.items():
+            db.execute(
+                pg_insert(Price)
+                .values(product_id=pid, price=price, period_id=item.id)
+                .on_conflict_do_update(constraint="uq_prices_period_id", set_=dict(price=price))
+            )
+    except SQLAlchemyError as e:
+        raise HTTPException(
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            detail=str(e),
+        )
+
+
+def get_issue_prices(period: Period, products: set[uuid.UUID], db: Session) -> dict[uuid.UUID, Decimal]:
+    sum_quantity = func.sum(
+        Inventory.quantity * StockKeepingUnit.fraction * StockKeepingUnit.product_yield * Journal.debit
+    ).label("quantity")
+    sum_net = func.sum(Inventory.rate * Inventory.quantity * Journal.debit).label("net")
+
+    d: dict[uuid.UUID, Decimal] = {}
+    query: list[tuple[uuid.UUID, Decimal]] = db.execute(
+        select(StockKeepingUnit.product_id, sum_net / sum_quantity)
+        .join(Inventory.batch)
+        .join(Batch.sku)
+        .join(Inventory.voucher)
+        .join(Voucher.journals)
+        .where(
+            Voucher.date_ >= period.valid_from,
+            Voucher.date_ <= period.valid_till,
+            Voucher.voucher_type.in_([VoucherType.ISSUE, VoucherType.CLOSING_STOCK]),
+            Journal.cost_centre_id != CostCentre.cost_centre_purchase(),
+            StockKeepingUnit.product_id.in_(products),
+        )
+        .group_by(StockKeepingUnit.product_id, Journal.debit)
+    ).all()
+    for id, amount in query:
+        d[id] = amount
+    return d
+
+
+def get_purchase_prices(period: Period, req: set[uuid.UUID], db: Session) -> dict[uuid.UUID, Decimal]:
+    sum_quantity = func.sum(
+        Inventory.quantity * StockKeepingUnit.fraction * StockKeepingUnit.product_yield * Journal.debit
+    ).label("quantity")
+    sum_net = func.sum(Inventory.rate * Inventory.quantity * Journal.debit).label("net")
+
+    d: dict[uuid.UUID, Decimal] = {}
+    query: list[tuple[uuid.UUID, Decimal]] = db.execute(
+        select(StockKeepingUnit.product_id, sum_net / sum_quantity)
+        .join(Inventory.batch)
+        .join(Batch.sku)
+        .join(Inventory.voucher)
+        .join(Voucher.journals)
+        .where(
+            Voucher.date_ >= period.valid_from,
+            Voucher.date_ <= period.valid_till,
+            Voucher.voucher_type == VoucherType.PURCHASE,
+            StockKeepingUnit.product_id.in_(req),
+        )
+        .group_by(StockKeepingUnit.product_id, Journal.debit)
+    ).all()
+    for id, amount in query:
+        d[id] = amount
+    return d
+
+
+def get_rest(req: set[uuid.UUID], db: Session) -> dict[uuid.UUID, Decimal]:
+    d: dict[uuid.UUID, Decimal] = {}
+    query = db.execute(
+        select(
+            StockKeepingUnit.product_id,
+            StockKeepingUnit.cost_price / (StockKeepingUnit.fraction * StockKeepingUnit.product_yield),
+        ).where(StockKeepingUnit.product_id.in_(req))
+    ).all()
+    for id, amount in query:
+        d[id] = amount
+    return d
+
+
+def calculate_recipes(recipes: set[uuid.UUID], prices: dict[uuid.UUID, Decimal], db: Session) -> None:
+    sq = select(RecipeItem.recipe_id).where(RecipeItem.product_id.in_(recipes))
+    items = (
+        db.execute(
+            select(Recipe).join(Recipe.sku).where(StockKeepingUnit.product_id.in_(recipes), Recipe.id.notin_(sq))
+        )
+        .scalars()
+        .all()
+    )
+    for item in items:
+        cost = sum(i.quantity * prices[i.product_id] for i in item.items) / (item.recipe_yield * item.sku.fraction)
+        prices[item.sku.product_id] = cost
+        recipes.remove(item.sku.product_id)

brewman/brewman/routers/fingerprint.py

@@ -8,7 +8,7 @@ from io import StringIO
 import brewman.schemas.fingerprint as schemas
 
 from fastapi import APIRouter, Depends, File, HTTPException, UploadFile, status
-from sqlalchemy import bindparam, select
+from sqlalchemy import select
 from sqlalchemy.dialects.postgresql import insert as pg_insert
 from sqlalchemy.exc import SQLAlchemyError
 from sqlalchemy.orm import Session
@@ -36,22 +36,13 @@ def upload_prints(
             for id_, code in db.execute(select(Employee.id, Employee.code)).all():
                 employees[code] = id_
             file_data = read_file(fingerprints)
-            prints = [d for d in fp(file_data, employees) if start <= d.date_.date() <= finish]
+            prints = [d.model_dump() for d in fp(file_data, employees) if start <= d.date_.date() <= finish]
+            for p in prints:
+                p["id"] = p.pop("id_")
             paged_data = [prints[i : i + 100] for i in range(0, len(prints), 100)]
             for i, page in enumerate(paged_data):
                 print(f"Processing page {i} of {len(paged_data)}")
-                db.execute(
-                    pg_insert(Fingerprint)
-                    .values(
-                        {
-                            "id": bindparam("id"),
-                            "employee_id": bindparam("employee_id"),
-                            "date": bindparam("date"),
-                        }
-                    )
-                    .on_conflict_do_nothing(),
-                    [p.dict() for p in page],
-                )
+                db.execute(pg_insert(Fingerprint).on_conflict_do_nothing(), page)
             db.commit()
     except SQLAlchemyError as e:
         raise HTTPException(

brewman/brewman/routers/recipe.py

@@ -11,6 +11,8 @@ from typing import Sequence
 import brewman.schemas.recipe as schemas
 import brewman.schemas.recipe_item as rischemas
 
+from brewman.models.price import Price
+from brewman.routers.calculate_prices import calculate_prices
 from fastapi import APIRouter, Depends, HTTPException, Request, Security, status
 from fastapi.responses import FileResponse, StreamingResponse
 from openpyxl import Workbook
@@ -58,6 +60,7 @@ def save(
                 instructions=data.instructions,
                 garnishing=data.garnishing,
                 plating=data.plating,
+                notes=data.notes,
                 sku=recipe_sku,
                 recipe_yield=round(data.recipe_yield, 2),
             )
@@ -71,7 +74,8 @@ def save(
                 r_item.recipe_id = recipe.id
                 db.add(r_item)
 
-            check_recursion(set([recipe_sku.product_id]), set(), recipe, db)
+            db.flush()
+            check_recursion(recipe_sku.product_id, set(), db)
             db.commit()
             return recipe_info(recipe)
     except SQLAlchemyError as e:
@@ -128,7 +132,8 @@ async def update_route(
                     RecipeItem(product_id=product.id, quantity=quantity, description=d_item.description)
                 )
 
-            check_recursion(set([sku.product_id]), set(), db)
+            db.flush()
+            check_recursion(sku.product_id, set(), db)
             db.commit()
             return recipe_info(recipe)
     except SQLAlchemyError as e:
@@ -138,26 +143,23 @@ async def update_route(
         )
 
 
-def check_recursion(products: set[uuid.UUID], visited: set[uuid.UUID], db: Session) -> None:
-    sq = (
-        select(func.distinct(RecipeItem.product_id))
-        .join(Recipe.items)
-        .join(Recipe.sku)
-        .where(StockKeepingUnit.product_id.in_(products))
-    )
-    ingredient_product_ids = (
-        db.execute(select(StockKeepingUnit.product_id).join(Recipe.sku).where(StockKeepingUnit.product_id.in_(sq)))
-        .scalars()
-        .all()
-    )
-    if len(ingredient_product_ids) == 0:
-        return
-    if (visited | products) & set(ingredient_product_ids):
+def check_recursion(product: uuid.UUID, visited: set[uuid.UUID], db: Session) -> None:
+    if product in visited:
         raise HTTPException(
             status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
             detail="Recipe recursion. Some ingredient recipe contains parent recipe.",
         )
-    check_recursion(set(ingredient_product_ids), visited | products, db)
+    recipe: Recipe = (
+        db.execute(select(Recipe).join(Recipe.items).join(Recipe.sku).where(StockKeepingUnit.product_id == product))
+        .unique()
+        .scalar_one_or_none()
+    )
+    if recipe is None:
+        return
+    visited.add(product)
+    for i in recipe.items:
+        check_recursion(i.product_id, visited, db)
+    visited.remove(product)
 
 
 @router.delete("/{id_}", response_model=None)
@@ -167,7 +169,6 @@ def delete_route(
     user: UserToken = Security(get_user, scopes=["recipes"]),
 ) -> None:
     with SessionFuture() as db:
-        recipe: Recipe = db.execute(select(Recipe).where(Recipe.id == id_)).scalar_one()
         recipe_ids: Sequence[uuid.UUID] = (
             db.execute(
                 select(func.distinct(RecipeItem.recipe_id)).where(
@@ -266,7 +267,22 @@ def show_pdf(
 @router.get("/xlsx", response_class=StreamingResponse)
 def get_report(
     p: uuid.UUID | None = None,
+    t: uuid.UUID | None = None,
 ) -> StreamingResponse:
+    with SessionFuture() as db:
+        calculate_prices(t, db)
+        db.commit()
+    prices: list[tuple[str, str, Decimal]] = []
+    with SessionFuture() as db:
+        pq = (
+            db.execute(select(Price).where(Price.period_id == t).options(joinedload(Price.product, innerjoin=True)))
+            .unique()
+            .scalars()
+            .all()
+        )
+        prices = [(i.product.name, i.product.fraction_units, i.price) for i in pq]
+
+    list_: Sequence[Recipe] = []
     with SessionFuture() as db:
         q = (
             select(Recipe)
@@ -280,17 +296,25 @@ def get_report(
         )
         if p is not None:
             q = q.where(Recipe.sku, StockKeepingUnit.product, Product.product_group_id == p)
-        list_: Sequence[Recipe] = db.execute(q).unique().scalars().all()
-        e = excel(sorted(list_, key=lambda r: r.sku.product.name))
-        e.seek(0)
+        list_ = db.execute(q).unique().scalars().all()
+    e = excel(prices, sorted(list_, key=lambda r: r.sku.product.name))
+    e.seek(0)
 
-        headers = {"Content-Disposition": "attachment; filename = recipe.xlsx"}
-        return StreamingResponse(e, media_type="text/xlsx", headers=headers)
+    headers = {"Content-Disposition": "attachment; filename = recipe.xlsx"}
+    return StreamingResponse(e, media_type="text/xlsx", headers=headers)
 
 
-def excel(recipes: list[Recipe]) -> BytesIO:
+def excel(prices: list[tuple[str, str, Decimal, Decimal, Decimal]], recipes: list[Recipe]) -> BytesIO:
     wb = Workbook()
     wb.active.title = "Rate List"
+    wb.active.cell(row=1, column=1, value="Name")
+    wb.active.cell(row=1, column=2, value="Units")
+    wb.active.cell(row=1, column=3, value="Rate")
+    for i, p in enumerate(prices, start=2):
+        wb.active.cell(row=i, column=1, value=p[0])
+        wb.active.cell(row=i, column=2, value=p[1])
+        wb.active.cell(row=i, column=3, value=p[2])
+
     pgs = set([x.sku.product.product_group.name for x in recipes])
     for pg in pgs:
         wb.create_sheet(pg)
@@ -299,6 +323,7 @@ def excel(recipes: list[Recipe]) -> BytesIO:
     for recipe in recipes:
         ws = wb[recipe.sku.product.product_group.name]
         row = rows[recipe.sku.product.product_group.name]
+        print(row)
         ings = len(recipe.items)
         ing_from = row + 2
         ing_till = ing_from + ings - 1
@@ -319,11 +344,11 @@ def excel(recipes: list[Recipe]) -> BytesIO:
             ws.cell(row=row, column=1, value=item.product.name).style = "ing"
             ws.cell(row=row, column=2, value=item.product.fraction_units).style = "unit"
             ws.cell(row=row, column=3, value=item.quantity).style = "ing"
-            ws.cell(row=row, column=4, value="=VLOOKUP(A:A,'Rate List'!A:G,7,0)").style = "ing"
+            ws.cell(row=row, column=4, value="=VLOOKUP(A:A,'Rate List'!A:C,3,0)").style = "ing"
             ws.cell(row=row, column=5, value=f"=C{row}*D{row}").style = "ing"
         rows[recipe.sku.product.product_group.name] = row + 1
-        virtual_workbook = BytesIO()
-        wb.save(virtual_workbook)
+    virtual_workbook = BytesIO()
+    wb.save(virtual_workbook)
     return virtual_workbook
 
 

brewman/brewman/schemas/client.py

@@ -44,11 +44,13 @@ class ClientList(Client):
 
     @field_validator("last_date", mode="before")
     @classmethod
-    def parse_last_date(cls, value: datetime | str) -> datetime | None:
+    def parse_last_date(cls, value: datetime | str | None) -> datetime | None:
+        if value is None or value == "":
+            return None
         if isinstance(value, datetime):
             return value
         return datetime.strptime(value, "%d-%b-%Y %H:%M")
 
     @field_serializer("last_date")
-    def serialize_last_date(self, value: datetime, info: FieldSerializationInfo) -> str:
-        return value.strftime("%d-%b-%Y %H:%M")
+    def serialize_last_date(self, value: datetime | None, info: FieldSerializationInfo) -> str | None:
+        return None if value is None else value.strftime("%d-%b-%Y %H:%M")

brewman/brewman/schemas/fingerprint.py

@@ -20,11 +20,11 @@ class Fingerprint(BaseModel):
 
     @field_validator("date_", mode="before")
     @classmethod
-    def parse_date(cls, value: date | str) -> date:
-        if isinstance(value, date):
+    def parse_date(cls, value: datetime | str) -> datetime:
+        if isinstance(value, datetime):
             return value
-        return datetime.strptime(value, "%d-%b-%Y").date()
+        return datetime.strptime(value, "%d-%b-%Y %H:%M")
 
     @field_serializer("date_")
     def serialize_date(self, value: date, info: FieldSerializationInfo) -> str:
-        return value.strftime("%d-%b-%Y")
+        return value.strftime("%d-%b-%Y %H:%M")

brewman/gunicorn.conf.py

@@ -0,0 +1,68 @@
+import json
+import multiprocessing
+import os
+
+
+workers_per_core_str = os.getenv("WORKERS_PER_CORE", "1")
+max_workers_str = os.getenv("MAX_WORKERS")
+use_max_workers = None
+if max_workers_str:
+    use_max_workers = int(max_workers_str)
+web_concurrency_str = os.getenv("WEB_CONCURRENCY", None)
+
+host = os.getenv("HOST", "0.0.0.0")
+port = os.getenv("PORT", "9994")
+bind_env = os.getenv("BIND", None)
+use_loglevel = os.getenv("LOG_LEVEL", "info")
+if bind_env:
+    use_bind = bind_env
+else:
+    use_bind = f"{host}:{port}"
+
+cores = multiprocessing.cpu_count()
+workers_per_core = float(workers_per_core_str)
+default_web_concurrency = workers_per_core * cores
+if web_concurrency_str:
+    web_concurrency = int(web_concurrency_str)
+    assert web_concurrency > 0
+else:
+    web_concurrency = max(int(default_web_concurrency), 2)
+    if use_max_workers:
+        web_concurrency = min(web_concurrency, use_max_workers)
+accesslog_var = os.getenv("ACCESS_LOG", "-")
+use_accesslog = accesslog_var or None
+errorlog_var = os.getenv("ERROR_LOG", "-")
+use_errorlog = errorlog_var or None
+graceful_timeout_str = os.getenv("GRACEFUL_TIMEOUT", "120")
+timeout_str = os.getenv("TIMEOUT", "120")
+keepalive_str = os.getenv("KEEP_ALIVE", "5")
+
+# Gunicorn config variables
+loglevel = use_loglevel
+workers = web_concurrency
+bind = use_bind
+errorlog = use_errorlog
+worker_tmp_dir = "/dev/shm"
+accesslog = use_accesslog
+graceful_timeout = int(graceful_timeout_str)
+timeout = int(timeout_str)
+keepalive = int(keepalive_str)
+
+
+# For debugging and testing
+log_data = {
+    "loglevel": loglevel,
+    "workers": workers,
+    "bind": bind,
+    "graceful_timeout": graceful_timeout,
+    "timeout": timeout,
+    "keepalive": keepalive,
+    "errorlog": errorlog,
+    "accesslog": accesslog,
+    # Additional, non-gunicorn variables
+    "workers_per_core": workers_per_core,
+    "use_max_workers": use_max_workers,
+    "host": host,
+    "port": port,
+}
+print(json.dumps(log_data))

brewman/logging.conf

@@ -0,0 +1,53 @@
+[loggers]
+keys=root, gunicorn.error, gunicorn.access
+
+[handlers]
+keys=console, error, access
+
+[formatters]
+keys=generic, error, access
+
+[logger_root]
+level=INFO
+handlers=console
+qualname=root
+
+[logger_gunicorn.error]
+level=INFO
+handlers=console
+qualname=gunicorn.error
+
+[logger_gunicorn.access]
+level=INFO
+handlers=access
+qualname=gunicorn.access
+
+[handler_console]
+class=StreamHandler
+formatter=generic
+args=(sys.stdout, )
+
+[handler_error]
+class=StreamHandler
+formatter=error
+args=(sys.stdout, )
+
+[handler_access]
+class=StreamHandler
+formatter=access
+args=(sys.stdout, )
+
+[formatter_generic]
+format=%(asctime)s [%(name)s %(levelname)s %(process)d] %(message)s
+datefmt=%Y-%m-%d %H:%M:%S %Z
+class=logging.Formatter
+
+[formatter_error]
+format=%(asctime)s [%(name)s %(levelname)s %(process)d] %(message)s | %(funcName)s() | %(pathname)s L%(lineno)-4d
+datefmt=%Y-%m-%d %H:%M:%S %Z
+class=logging.Formatter
+
+[formatter_access]
+format=%(asctime)s [%(name)s %(levelname)s %(process)d] %(message)s
+datefmt=%Y-%m-%d %H:%M:%S %Z
+class=logging.Formatter

brewman/pyproject.toml

@@ -1,27 +1,28 @@
 [tool.poetry]
 name = "brewman"
-version = "11.1.4"
+version = "11.3.0"
 description = "Accounting plus inventory management for a restaurant."
 authors = ["tanshu <git@tanshu.com>"]
 
 [tool.poetry.dependencies]
 python = "^3.11"
-uvicorn = {extras = ["standard"], version = "^0.21.1"}
-fastapi = {extras = ["all"], version = "^0.100.0"}
+uvicorn = {extras = ["standard"], version = "^0.23.2"}
+fastapi = {extras = ["all"], version = "^0.101.0"}
 python-jose = {extras = ["cryptography"], version = "^3.3.0"}
 passlib = {extras = ["bcrypt"], version = "^1.7.4"}
-psycopg2-binary = "^2.9.5"
-SQLAlchemy = "^2.0.7"
+psycopg2-binary = "^2.9.7"
+SQLAlchemy = "^2.0.19"
 python-multipart = "^0.0.6"
 PyJWT = "^2.8.0"
-alembic = "^1.11.1"
+alembic = "^1.11.2"
 itsdangerous = "^2.1.2"
 python-dotenv = "^1.0.0"
-pydantic = {extras = ["dotenv"], version = "^2.0.3"}
+pydantic = {extras = ["dotenv"], version = "^2.1.1"}
 starlette = "^0.27.0"
 pandas = "^2.0.0"
 arq = "^0.25.0"
 openpyxl = "^3.1.2"
+gunicorn = "^21.2.0"
 
 [tool.poetry.group.dev.dependencies]
 flake8 = "^6.0.0"

brewman/run.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+set -euo pipefail
+gunicorn brewman.main:app --worker-class uvicorn.workers.UvicornWorker --config ./gunicorn.conf.py --log-config ./logging.conf

deploy.sh

@@ -32,5 +32,5 @@ else
   echo "No version bump"
 fi
 cd "$parent_path/docker" || exit
-docker save brewman:latest | bzip2 | pv | ssh beacon 'bunzip2 | sudo docker load'
+docker save brewman:latest | bzip2 | pv | ssh gondor 'bunzip2 | sudo docker load'
 ansible-playbook --inventory hosts playbook.yml

docker/app/Dockerfile

@@ -50,4 +50,4 @@ RUN chmod 777 /app/docker-entrypoint.sh \
     && ln -s /app/docker-entrypoint.sh /
 ENTRYPOINT ["docker-entrypoint.sh"]
 
-CMD ["poetry", "run", "python", "-m", "brewman"]
+CMD ["poetry", "run", "gunicorn", "brewman.main:app", "--worker-class", "uvicorn.workers.UvicornWorker", "--config", "/app/gunicorn.conf.py", "--log-config", "/app/logging.conf"]

docker/files/.env

@@ -2,15 +2,11 @@ HOST=0.0.0.0
 PORT=80
 LOG_LEVEL=WARN
 DEBUG=false
-SQLALCHEMY_DATABASE_URI=postgresql://postgres:123456@db:5432/brewman_hinchco
+SQLALCHEMY_DATABASE_URI=postgresql://postgres:123456@db:5432/brewman_{{ name }}
 MODULE_NAME=brewman.main
 PROJECT_NAME=brewman
-POSTGRES_SERVER=db
-POSTGRES_USER=postgres
-POSTGRES_PASSWORD=123456
-POSTGRES_DB=brewman_hinchco
-SECRET_KEY=7b889cff76532fde8483304cf415243f70df200518ba9aee4d26c0709ad6fbd1
-MIDDLEWARE_SECRET_KEY=1e36e7f678
+SECRET_KEY={{ secret_key }}
+MIDDLEWARE_SECRET_KEY={{ middleware_key }}
 ALGORITHM=HS256
 JWT_TOKEN_EXPIRE_MINUTES=30
 ALEMBIC_LOG_LEVEL=INFO

docker/files/.env-acc

@@ -1,17 +0,0 @@
-HOST=0.0.0.0
-PORT=80
-LOG_LEVEL=WARN
-DEBUG=false
-SQLALCHEMY_DATABASE_URI=postgresql://postgres:123456@db:5432/acc
-MODULE_NAME=brewman.main
-PROJECT_NAME=brewman
-POSTGRES_SERVER=db
-POSTGRES_USER=postgres
-POSTGRES_PASSWORD=123456
-POSTGRES_DB=exp
-SECRET_KEY=c9bee2d38676447c2f7a9ea715446e2fd09f16fbaa5b3f6a6f207ec18993987f
-MIDDLEWARE_SECRET_KEY=cb71666b9c
-ALGORITHM=HS256
-JWT_TOKEN_EXPIRE_MINUTES=30
-ALEMBIC_LOG_LEVEL=INFO
-ALEMBIC_SQLALCHEMY_LOG_LEVEL=WARN

docker/files/.env-exp

@@ -1,17 +0,0 @@
-HOST=0.0.0.0
-PORT=80
-LOG_LEVEL=WARN
-DEBUG=false
-SQLALCHEMY_DATABASE_URI=postgresql://postgres:123456@db:5432/exp
-MODULE_NAME=brewman.main
-PROJECT_NAME=brewman
-POSTGRES_SERVER=db
-POSTGRES_USER=postgres
-POSTGRES_PASSWORD=123456
-POSTGRES_DB=exp
-SECRET_KEY=8546a61262dab7c05ccf2e26abe30bc10966904df6dfd29259ea85dd0844a8e7
-MIDDLEWARE_SECRET_KEY=da6fcd999b
-ALGORITHM=HS256
-JWT_TOKEN_EXPIRE_MINUTES=30
-ALEMBIC_LOG_LEVEL=INFO
-ALEMBIC_SQLALCHEMY_LOG_LEVEL=WARN

docker/files/.env-hops

@@ -1,17 +0,0 @@
-HOST=0.0.0.0
-PORT=80
-LOG_LEVEL=WARN
-DEBUG=false
-SQLALCHEMY_DATABASE_URI=postgresql://postgres:123456@db:5432/hops
-MODULE_NAME=brewman.main
-PROJECT_NAME=brewman
-POSTGRES_SERVER=db
-POSTGRES_USER=postgres
-POSTGRES_PASSWORD=123456
-POSTGRES_DB=exp
-SECRET_KEY=cfb3be420c4e2b0ed423b2e4e238713d0461e2ba56198138ad6c4d82aef6295c
-MIDDLEWARE_SECRET_KEY=9c2bdd24be
-ALGORITHM=HS256
-JWT_TOKEN_EXPIRE_MINUTES=30
-ALEMBIC_LOG_LEVEL=INFO
-ALEMBIC_SQLALCHEMY_LOG_LEVEL=WARN

docker/files/.env-mhl

@@ -1,17 +0,0 @@
-HOST=0.0.0.0
-PORT=80
-LOG_LEVEL=WARN
-DEBUG=false
-SQLALCHEMY_DATABASE_URI=postgresql://postgres:123456@db:5432/mhl
-MODULE_NAME=brewman.main
-PROJECT_NAME=brewman
-POSTGRES_SERVER=db
-POSTGRES_USER=postgres
-POSTGRES_PASSWORD=123456
-POSTGRES_DB=exp
-SECRET_KEY=c9fd1b99931feb083f67470170650420b99eb35368d3de186427166c28d32c8b
-MIDDLEWARE_SECRET_KEY=9183bdcfb0
-ALGORITHM=HS256
-JWT_TOKEN_EXPIRE_MINUTES=30
-ALEMBIC_LOG_LEVEL=INFO
-ALEMBIC_SQLALCHEMY_LOG_LEVEL=WARN

docker/hosts

@@ -5,11 +5,11 @@
 #   - A hostname/ip can be a member of multiple groups
 
 [brewman]
-acc ansible_host=beacon var_file=vars/acc.yml
-exp ansible_host=beacon var_file=vars/exp.yml
-hops ansible_host=beacon var_file=vars/hops.yml
-mhl ansible_host=beacon var_file=vars/mhl.yml
-hinchco ansible_host=beacon var_file=vars/hinchco.yml
+acc ansible_host=gondor var_file=vars/acc.yml
+exp ansible_host=gondor var_file=vars/exp.yml
+hops ansible_host=gondor var_file=vars/hops.yml
+mhl ansible_host=gondor var_file=vars/mhl.yml
+hinchco ansible_host=gondor var_file=vars/hinchco.yml
 
 [all:vars]
 ansible_python_interpreter=/usr/bin/python3

docker/playbook.yml

@@ -6,6 +6,7 @@
   become: true
   vars_files:
     - "{{ var_file }}"
+    - vars/default.yml
 
   tasks:
     - name: Copy dockerfile
@@ -30,7 +31,7 @@
 
     - name: Upload the .env file
       template:
-        src: "{{ env_file }}"
+        src: "files/.env"
         dest: "/var/lib/{{ host_directory }}/.env"
 
     - name: Create brewman container
@@ -40,8 +41,10 @@
         state: started
         restart_policy: "unless-stopped"
         env_file: "/var/lib/{{ host_directory }}/.env"
-        links:
-          - "postgres:db"
+        etc_hosts:
+          db : "{{ db_host }}"
+        # links:
+        #   - "postgres:db"
         published_ports:
           - "127.0.0.1:{{ host_port }}:80"
         volumes:

docker/vars/acc.yml

@@ -1,6 +1,9 @@
 ---
+name: acc
+
 http_host: "acc.hopsngrains.com"
 http_conf: "acc.hopsngrains.com.conf"
 host_port: "8659"
-host_directory: "brewman-acc"
-env_file: "files/.env-acc"
+
+secret_key: c9bee2d38676447c2f7a9ea715446e2fd09f16fbaa5b3f6a6f207ec18993987f
+middleware_key: cb71666b9c

docker/vars/default.yml

@@ -0,0 +1,4 @@
+---
+db_host: 172.26.12.67
+host_directory: "brewman-{{ name }}"
+db_name: "brewman_{{ name }}"

docker/vars/exp.yml

@@ -1,6 +1,9 @@
 ---
+name: exp
+
 http_host: "exp.tanshu.com"
 http_conf: "exp.tanshu.com.conf"
 host_port: "8656"
-host_directory: "brewman-exp"
-env_file: "files/.env-exp"
+
+secret_key: 8546a61262dab7c05ccf2e26abe30bc10966904df6dfd29259ea85dd0844a8e7
+middleware_key: da6fcd999b

docker/vars/hinchco.yml

@@ -1,6 +1,9 @@
 ---
+name: hinchco
+
 http_host: "acc.hinchco.in"
 http_conf: "acc.hinchco.in.conf"
 host_port: "8655"
-host_directory: "brewman-hinchco"
-env_file: "files/.env-hinchco"
+
+secret_key: 7b889cff76532fde8483304cf415243f70df200518ba9aee4d26c0709ad6fbd1
+middleware_key: 1e36e7f678

docker/vars/hops.yml

@@ -1,6 +1,9 @@
 ---
+name: hops
+
 http_host: "hops.hopsngrains.com"
 http_conf: "hops.hopsngrains.com.conf"
 host_port: "8658"
-host_directory: "brewman-hops"
-env_file: "files/.env-hops"
+
+secret_key: cfb3be420c4e2b0ed423b2e4e238713d0461e2ba56198138ad6c4d82aef6295c
+middleware_key: 9c2bdd24be

docker/vars/mhl.yml

@@ -1,6 +1,9 @@
 ---
+name: mhl
+
 http_host: "mhl.hopsngrains.com"
 http_conf: "mhl.hopsngrains.com.conf"
 host_port: "8657"
-host_directory: "brewman-mhl"
-env_file: "files/.env-mhl"
+
+secret_key: c9fd1b99931feb083f67470170650420b99eb35368d3de186427166c28d32c8b
+middleware_key: 9183bdcfb0

overlord/package.json

@@ -1,6 +1,6 @@
 {
   "name": "overlord",
-  "version": "11.1.4",
+  "version": "11.3.0",
   "scripts": {
     "ng": "ng",
     "start": "ng serve",

overlord/src/app/employee-benefits/employee-benefits.component.ts

@@ -148,8 +148,8 @@ export class EmployeeBenefitsComponent implements OnInit, AfterViewInit {
     if (formValue === undefined) {
       return;
     }
-    const grossSalary = +(formValue.grossSalary ?? '0');
-    const daysWorked = +(formValue.daysWorked ?? '0');
+    const grossSalary = Number(formValue.grossSalary);
+    const daysWorked = Number(formValue.daysWorked);
     const date = this.form.value.date ?? new Date();
     const daysInMonth = moment(date).daysInMonth();
     const esi = EmployeeBenefitsComponent.getEsi(grossSalary, daysWorked, daysInMonth);

overlord/src/app/employee/employee-detail/employee-detail.component.ts

@@ -129,8 +129,8 @@ export class EmployeeDetailComponent implements OnInit, AfterViewInit {
     const formValue = this.form.value;
     this.item.name = formValue.name ?? '';
     this.item.designation = formValue.designation ?? '';
-    this.item.salary = +(formValue.salary ?? '0');
-    this.item.points = +(formValue.points ?? '0');
+    this.item.salary = Number(formValue.salary);
+    this.item.points = Number(formValue.points);
     this.item.isActive = formValue.isActive ?? true;
     this.item.costCentre.id = formValue.costCentre ?? '';
     this.item.joiningDate = moment(formValue.joiningDate).format('DD-MMM-YYYY');

overlord/src/app/issue/issue.component.ts

@@ -193,10 +193,10 @@ export class IssueComponent implements OnInit, AfterViewInit, OnDestroy {
       this.voucher.inventories.push(
         new Inventory({
           quantity,
-          rate: this.batch.rate,
-          tax: this.batch.tax,
-          discount: this.batch.discount,
-          amount: quantity * this.batch.rate * (1 + this.batch.tax) * (1 - this.batch.discount),
+          rate: +this.batch.rate,
+          tax: +this.batch.tax,
+          discount: +this.batch.discount,
+          amount: quantity * +this.batch.rate * (1 + +this.batch.tax) * (1 - +this.batch.discount),
           batch: this.batch,
         }),
       );

overlord/src/app/product-ledger/product-ledger-datasource.ts

@@ -62,13 +62,13 @@ export class ProductLedgerDataSource extends DataSource<ProductLedgerItem> {
         case 'date':
           return compare(a.date, b.date, isAsc);
         case 'debitQuantity':
-          return compare(Number(a.debitQuantity ?? '0'), Number(b.debitQuantity ?? '0'), isAsc);
+          return compare(Number(a.debitQuantity), Number(b.debitQuantity), isAsc);
         case 'debitAmount':
-          return compare(Number(a.debitAmount ?? '0'), Number(b.debitAmount ?? '0'), isAsc);
+          return compare(Number(a.debitAmount), Number(b.debitAmount), isAsc);
         case 'creditQuantity':
-          return compare(Number(a.creditQuantity ?? '0'), Number(b.creditQuantity ?? '0'), isAsc);
+          return compare(Number(a.creditQuantity), Number(b.creditQuantity), isAsc);
         case 'creditAmount':
-          return compare(Number(a.creditAmount ?? '0'), Number(b.creditAmount ?? '0'), isAsc);
+          return compare(Number(a.creditAmount), Number(b.creditAmount), isAsc);
         default:
           return 0;
       }

overlord/src/app/product-ledger/product-ledger.component.ts

@@ -113,12 +113,12 @@ export class ProductLedgerComponent implements OnInit, AfterViewInit {
     this.runningAmount = 0;
     this.info.body.forEach((item) => {
       if (item.type !== 'Opening Balance') {
-        this.debitAmount += Number(item.debitAmount ?? '0');
-        this.creditQuantity += Number(item.creditQuantity ?? '0');
-        this.creditAmount += Number(item.creditAmount ?? '0');
+        this.debitAmount += Number(item.debitAmount);
+        this.creditQuantity += Number(item.creditQuantity);
+        this.creditAmount += Number(item.creditAmount);
       }
-      this.runningQuantity += Number(item.debitQuantity ?? '0') - Number(item.creditQuantity ?? '0');
-      this.runningAmount += Number(item.debitAmount ?? '0') - Number(item.creditAmount ?? '0');
+      this.runningQuantity += Number(item.debitQuantity) - Number(item.creditQuantity);
+      this.runningAmount += Number(item.debitAmount) - Number(item.creditAmount);
       item.runningQuantity = this.runningQuantity;
       item.runningAmount = this.runningAmount;
     });

overlord/src/app/product/product-detail/product-detail.component.ts

@@ -113,22 +113,22 @@ export class ProductDetailComponent implements OnInit, AfterViewInit {
     if (formValue === undefined) {
       return;
     }
-    const fraction = +(formValue.fraction ?? '0');
+    const fraction = Number(formValue.fraction);
     if (fraction < 1) {
       this.toaster.show('Danger', 'Fraction has to be >= 1');
       return;
     }
-    const productYield = +(formValue.productYield ?? '0');
+    const productYield = Number(formValue.productYield);
     if (productYield < 0 || productYield > 1) {
       this.toaster.show('Danger', 'Product Yield has to be > 0 and <= 1');
       return;
     }
-    const costPrice = +(formValue.costPrice ?? '0');
+    const costPrice = Number(formValue.costPrice);
     if (costPrice < 0) {
       this.toaster.show('Danger', 'Price has to be >= 0');
       return;
     }
-    const salePrice = +(formValue.salePrice ?? '0');
+    const salePrice = Number(formValue.salePrice);
     if (salePrice < 0) {
       this.toaster.show('Danger', 'Sale Price has to be >= 0');
       return;

overlord/src/app/recipe/recipe-detail/recipe-detail.component.html

@@ -24,7 +24,7 @@
         </mat-form-field>
       </div>
       <div class="flex flex-row justify-around content-start items-start sm:max-lg:flex-col">
-        <mat-form-field class="flex-auto basis-3/5 mr-5">
+        <mat-form-field class="flex-auto basis-4/5 mr-5">
           <mat-label>Product</mat-label>
           <input
             type="text"
@@ -43,7 +43,7 @@
             <mat-option *ngFor="let product of products | async" [value]="product">{{ product.name }}</mat-option>
           </mat-autocomplete>
         </mat-form-field>
-        <mat-form-field class="flex-auto basis-1/10 mr-5">
+        <mat-form-field class="flex-auto basis-1/5">
           <mat-label>Yield</mat-label>
           <input type="text" matInput formControlName="recipeYield" autocomplete="off" />
         </mat-form-field>
@@ -74,17 +74,12 @@
           <mat-label>Quantity</mat-label>
           <input type="text" matInput formControlName="quantity" autocomplete="off" />
         </mat-form-field>
-        <mat-form-field class="flex-auto basis-1/5 mr-5">
+        <mat-form-field class="flex-auto basis-[30%] mr-5">
           <mat-label>Description</mat-label>
           <input type="text" matInput formControlName="description" autocomplete="off" />
         </mat-form-field>
-        <mat-form-field class="flex-auto basis-1/10 mr-5">
-          <mat-label>Rate</mat-label>
-          <input type="text" matInput formControlName="rate" autocomplete="off" />
-          <span matTextPrefix>₹&nbsp;</span>
-        </mat-form-field>
 
-        <button mat-raised-button color="primary" (click)="addRow()" class="flex-auto basis-1/10">Add</button>
+        <button mat-raised-button color="primary" (click)="addRow()" class="flex-auto basis-[10%]">Add</button>
       </div>
       <mat-table #table [dataSource]="dataSource" matSort aria-label="Elements">
         <!-- Ingredient Column -->

overlord/src/app/recipe/recipe-detail/recipe-detail.component.ts

@@ -39,7 +39,6 @@ export class RecipeDetailComponent implements OnInit, AfterViewInit {
       ingredient: FormControl<string | null>;
       quantity: FormControl<string>;
       description: FormControl<string>;
-      rate: FormControl<string>;
     }>;
     instructions: FormControl<string>;
     garnishing: FormControl<string>;
@@ -75,7 +74,6 @@ export class RecipeDetailComponent implements OnInit, AfterViewInit {
         ingredient: new FormControl(''),
         quantity: new FormControl('', { nonNullable: true }),
         description: new FormControl('', { nonNullable: true }),
-        rate: new FormControl('', { nonNullable: true }),
       }),
       instructions: new FormControl('', { nonNullable: true }),
       garnishing: new FormControl('', { nonNullable: true }),
@@ -118,7 +116,6 @@ export class RecipeDetailComponent implements OnInit, AfterViewInit {
         ingredient: null,
         quantity: '',
         description: '',
-        rate: '',
       },
       instructions: item.instructions,
       garnishing: item.garnishing,
@@ -160,8 +157,7 @@ export class RecipeDetailComponent implements OnInit, AfterViewInit {
       return;
     }
     const quantity = this.math.parseAmount(formValue.quantity, 2);
-    const rate = this.math.parseAmount(formValue.rate, 2);
-    if (this.ingredient === null || quantity <= 0 || rate <= 0) {
+    if (this.ingredient === null || quantity <= 0) {
       return;
     }
     const oldFiltered = this.item.items.filter((x) => x.product.id === (this.ingredient as ProductSku).id);

overlord/src/app/recipe/recipe-list/recipe-list.component.html

@@ -2,7 +2,7 @@
   <mat-card-header>
     <mat-card-title-group>
       <mat-card-title>Recipes</mat-card-title>
-      <a mat-icon-button href="{{ excelLink() }}">
+      <a mat-icon-button [href]="'/api/recipes/xlsx?t=' + period.id">
         <mat-icon>save_alt</mat-icon>
       </a>
       <a mat-button [routerLink]="['/recipes', 'new']">

overlord/src/app/recipe/recipe-list/recipe-list.component.ts

@@ -31,6 +31,7 @@ export class RecipeListComponent implements OnInit {
   list: Recipe[] = [];
   data: BehaviorSubject<Recipe[]> = new BehaviorSubject<Recipe[]>([]);
   dataSource: RecipeListDatasource = new RecipeListDatasource(this.productGroupFilter, this.data);
+  period: Period = new Period();
 
   /** Columns displayed in the table. Columns IDs can be added, removed, or reordered. */
   displayedColumns = ['name', 'yield', 'date', 'source'];
@@ -44,13 +45,14 @@ export class RecipeListComponent implements OnInit {
       productGroup: new FormControl<ProductGroup | string | null>(null),
     });
     // Listen to Payment Account Change
-    this.form.controls.period.valueChanges.subscribe((x) =>
+    this.form.controls.period.valueChanges.subscribe((x) => {
       this.router.navigate([], {
         relativeTo: this.route,
         queryParams: { p: x.id },
         replaceUrl: true,
-      }),
-    );
+      });
+      this.period = x;
+    });
   }
 
   ngOnInit() {
@@ -73,8 +75,4 @@ export class RecipeListComponent implements OnInit {
   filterProductGroup(val: string) {
     this.productGroupFilter.next(val || '');
   }
-
-  excelLink() {
-    return `/api/recipes/xlsx`;
-  }
 }

overlord/src/environments/environment.prod.ts

@@ -2,5 +2,5 @@ export const environment = {
   production: true,
   // eslint-disable-next-line @typescript-eslint/naming-convention
   ACCESS_TOKEN_REFRESH_MINUTES: 10, // refresh token 10 minutes before expiry
-  version: '11.1.4',
+  version: '11.3.0',
 };

overlord/src/environments/environment.ts

@@ -6,7 +6,7 @@ export const environment = {
   production: false,
   // eslint-disable-next-line @typescript-eslint/naming-convention
   ACCESS_TOKEN_REFRESH_MINUTES: 10, // refresh token 10 minutes before expiry
-  version: '11.1.4',
+  version: '11.3.0',
 };
 
 /*