Removed IsModifierCompulsory from MenuCategory as it is now not needed and minimum in ModifierCategory set to non-zero to achieve the same.

Fix: DiscountLimit was not scaled to 100 in MenuCategory detail. So it is now chaled in the json and scaled back in the frontend for the list as that was not supposed to be scaled.
Feature: Modifier is now done
Fix: In product save, it was checking menu_category second time again instead of sale_category

bookie/src/app/modifier-categories/modifier-category-detail/modifier-category-detail.component.ts

@@ -1,7 +1,7 @@
 import {AfterViewInit, Component, ElementRef, OnInit, ViewChild} from '@angular/core';
 import {ActivatedRoute, Router} from '@angular/router';
 import {ModifierCategoryService} from '../modifier-category.service';
-import {ModifierCategory} from '../modifier-category';
+import {ModifierCategory} from '../../core/modifier-category';
 import {ToasterService} from '../../core/toaster.service';
 import {ConfirmDialogComponent} from '../../shared/confirm-dialog/confirm-dialog.component';
 import {MatDialog} from '@angular/material/dialog';

bookie/src/app/modifier-categories/modifier-category-list-resolver.service.ts

@@ -1,6 +1,6 @@
 import {Injectable} from '@angular/core';
 import {ActivatedRouteSnapshot, Resolve, Router, RouterStateSnapshot} from '@angular/router';
-import {ModifierCategory} from './modifier-category';
+import {ModifierCategory} from '../core/modifier-category';
 import {Observable} from 'rxjs/internal/Observable';
 import {ModifierCategoryService} from './modifier-category.service';
 

bookie/src/app/modifier-categories/modifier-category-list/modifier-category-list-datasource.ts

@@ -1,6 +1,6 @@
 import { DataSource } from '@angular/cdk/collections';
 import { Observable, of as observableOf } from 'rxjs';
-import { ModifierCategory } from '../modifier-category';
+import { ModifierCategory } from '../../core/modifier-category';
 
 export class ModifierCategoryListDatasource extends DataSource<ModifierCategory> {
 

bookie/src/app/modifier-categories/modifier-category-list/modifier-category-list.component.ts

@@ -1,6 +1,6 @@
 import { Component, OnInit } from '@angular/core';
 import { ModifierCategoryListDatasource } from './modifier-category-list-datasource';
-import { ModifierCategory } from '../modifier-category';
+import { ModifierCategory } from '../../core/modifier-category';
 import { ActivatedRoute } from '@angular/router';
 
 @Component({

bookie/src/app/modifier-categories/modifier-category-resolver.service.ts

@@ -1,6 +1,6 @@
 import {Injectable} from '@angular/core';
 import {ActivatedRouteSnapshot, Resolve, Router, RouterStateSnapshot} from '@angular/router';
-import {ModifierCategory} from './modifier-category';
+import {ModifierCategory} from '../core/modifier-category';
 import {Observable} from 'rxjs/internal/Observable';
 import {ModifierCategoryService} from './modifier-category.service';
 

bookie/src/app/modifier-categories/modifier-category.service.ts

@@ -3,7 +3,7 @@ import {HttpClient, HttpHeaders, HttpParams} from '@angular/common/http';
 import {ErrorLoggerService} from '../core/error-logger.service';
 import {catchError} from 'rxjs/operators';
 import {Observable} from 'rxjs/internal/Observable';
-import {ModifierCategory} from './modifier-category';
+import {ModifierCategory} from '../core/modifier-category';
 
 const httpOptions = {
   headers: new HttpHeaders({'Content-Type': 'application/json'})

bookie/src/app/modifier-categories/modifier-category.ts

@@ -1,9 +0,0 @@
-import {MenuCategory} from "../core/menu-category";
-
-export class ModifierCategory {
-  id: string;
-  name: string;
-  minimum: number;
-  maximum: number;
-  menuCategories: MenuCategory[];
-}