Fix: Inactive Menu Categories should not show up in sales.

Trying to better cache dockerfile
This commit is contained in:
2021-06-21 12:37:49 +05:30
parent 5d5439ae3b
commit 1c222872d2
2 changed files with 10 additions and 8 deletions

View File

@ -2,7 +2,7 @@ import uuid
from datetime import date
from operator import and_, or_
from typing import List, Optional
from typing import List
import barker.schemas.menu_category as schemas
@ -115,11 +115,11 @@ def show_blank(
@router.get("/list", response_model=List[schemas.MenuCategory])
def show_list(
p: Optional[bool] = None,
p: bool = False,
date_: date = Depends(effective_date),
user: UserToken = Depends(get_user),
) -> List[schemas.MenuCategory]:
if p is not None:
if p:
sq = select(distinct(ProductVersion.menu_category_id)).where(
and_(
or_(
@ -134,7 +134,7 @@ def show_list(
)
query = (
select(MenuCategory)
.where(MenuCategory.id.in_(sq))
.where(MenuCategory.id.in_(sq), MenuCategory.is_active == True) # noqa: E712
.order_by(MenuCategory.sort_order)
.order_by(MenuCategory.name)
)