Fix: Reload was not working due to changes in how Signals and inputs work. On reload, the input does not change so the resource does not fetch new data.

.vscode/settings.json

@@ -1,6 +1,12 @@
 {
-  // Use WSL paths + Poetry venv interpreter
+  "python.defaultInterpreterPath": "/brewman/.venv/bin/python",
-  "python.defaultInterpreterPath": "${workspaceFolder}/brewman/.venv/bin/python",
+  "python.terminal.useEnvFile": true,
+  "python.venvFolders": [
+    "barker/.venv",
+    "frank/.venv",
+    ".venv"
+  ],
+  "python.venvPath": "${workspaceFolder}/barker",
   "python.terminal.activateEnvironment": true,
    // Quality-of-life
   /* --- Pylance: keep IntelliSense, disable type checking --- */
@@ -8,6 +14,11 @@
   // "python.analysis.diagnosticMode": "openFilesOnly",
   "python.analysis.typeCheckingMode": "basic",
   "python.analysis.extraPaths": [
+    "${workspaceFolder}/brewman",
+    "./brewman"
+  ],
+  "python.autoComplete.extraPaths": [
+    "${workspaceFolder}/brewman",
     "./brewman"
   ],
   // Ruff (you have ruff installed via poetry)

overlord/src/app/app.config.ts

@@ -10,7 +10,7 @@ import { MomentDateAdapter } from '@angular/material-moment-adapter';
 import { DateAdapter, MAT_DATE_FORMATS, MAT_DATE_LOCALE } from '@angular/material/core';
 import { MAT_SNACK_BAR_DEFAULT_OPTIONS } from '@angular/material/snack-bar';
 import { BrowserModule } from '@angular/platform-browser';
-import { provideRouter, withComponentInputBinding, withRouterConfig } from '@angular/router';
+import { provideRouter, withComponentInputBinding } from '@angular/router';
 
 import { dateFormat } from './app.environment';
 import { routes } from './app.routes';
@@ -33,13 +33,7 @@ export const appConfig: ApplicationConfig = {
         ...(isDevMode() ? [delayInterceptor] : []),
       ]),
     ),
-    provideRouter(
+    provideRouter(routes, withComponentInputBinding()),
-      routes,
-      withRouterConfig({
-        onSameUrlNavigation: 'reload',
-      }),
-      withComponentInputBinding(),
-    ),
     { provide: DateAdapter, useClass: MomentDateAdapter, deps: [MAT_DATE_LOCALE] },
     { provide: MAT_DATE_FORMATS, useValue: dateFormat },
     { provide: MAT_SNACK_BAR_DEFAULT_OPTIONS, useValue: { duration: 3000 } },

overlord/src/app/attendance/attendance.component.ts

@@ -99,8 +99,12 @@ export class AttendanceComponent {
 
   show() {
     const date = moment(this.model().date).format('DD-MMM-YYYY');
+    if (this.date() === date) {
+      this.infoResource.reload();
+    } else {
       this.router.navigate(['/attendance', date]);
     }
+  }
 
   save() {
     this.ser.save(this.getAttendance()).subscribe({

overlord/src/app/attendance/attendance.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Attendance',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':date',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Attendance',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/balance-sheet/balance-sheet.component.ts

@@ -112,8 +112,12 @@ export class BalanceSheetComponent {
 
   show() {
     const date = this.getDate();
+    if (this.date() === date) {
+      this.infoResource.reload();
+    } else {
       this.router.navigate(['balance-sheet', date]);
     }
+  }
 
   getDate(): string {
     const formModel = this.formModel();

overlord/src/app/balance-sheet/balance-sheet.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Balance Sheet',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':date',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Balance Sheet',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/batch-integrity-report/batch-integrity-report.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'Product Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/cash-flow/cash-flow.component.ts

@@ -105,6 +105,9 @@ export class CashFlowComponent {
 
   show() {
     const info = this.getInfo();
+    if (this.startDate() === info.startDate && this.finishDate() === info.finishDate) {
+      this.infoResource.reload();
+    } else {
       this.router.navigate(['cash-flow'], {
         queryParams: {
           startDate: info.startDate,
@@ -112,6 +115,7 @@ export class CashFlowComponent {
         },
       });
     }
+  }
 
   getInfo(): CashFlow {
     const formModel = this.model();

overlord/src/app/cash-flow/cash-flow.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Cash Flow',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Cash Flow',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/closing-stock/closing-stock.component.ts

@@ -151,12 +151,16 @@ export class ClosingStockComponent {
       return;
     }
     const info = this.getInfo();
+    if (this.date() === info.date && this.d() === info.costCentre.id) {
+      this.infoResource.reload();
+    } else {
       this.router.navigate(['closing-stock', info.date], {
         queryParams: {
           d: info.costCentre.id,
         },
       });
     }
+  }
 
   save() {
     this.ser.save(this.getClosingStock()).subscribe({

overlord/src/app/closing-stock/closing-stock.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Closing Stock',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':date',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Closing Stock',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/daybook/daybook.component.ts

@@ -127,6 +127,9 @@ export class DaybookComponent {
 
   show() {
     const l = this.prepareSubmit();
+    if (this.startDate() === l.startDate && this.finishDate() === l.finishDate) {
+      this.infoResource.reload();
+    } else {
       this.router.navigate(['daybook'], {
         queryParams: {
           startDate: l.startDate,
@@ -134,6 +137,7 @@ export class DaybookComponent {
         },
       });
     }
+  }
 
   prepareSubmit(): Daybook {
     const formModel = this.model();

overlord/src/app/daybook/daybook.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'Daybook',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/employee-attendance/employee-attendance.component.ts

@@ -126,6 +126,13 @@ export class EmployeeAttendanceComponent {
     currentInfo.employee =
       typeof formValue.employee !== 'string' && formValue.employee ? formValue.employee : undefined;
     if (currentInfo.employee) {
+      if (
+        this.id() === currentInfo.employee.id &&
+        this.startDate() === currentInfo.startDate &&
+        this.finishDate() === currentInfo.finishDate
+      ) {
+        this.infoResource.reload();
+      } else {
         this.router.navigate(['/employee-attendance', currentInfo.employee.id], {
           queryParams: {
             startDate: currentInfo.startDate,
@@ -134,6 +141,7 @@ export class EmployeeAttendanceComponent {
         });
       }
     }
+  }
 
   save() {
     this.ser.save(this.getEmployeeAttendance()).subscribe({

overlord/src/app/employee-attendance/employee-attendance.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Attendance',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Attendance',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/employee-benefits/employee-benefits.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'employee-benefit',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'employee-benefit',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/employee-functions/employee-functions.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'employee-benefit',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/entries/entries.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/incentive/incentive.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'incentive',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'incentive',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/issue/issue.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Issue',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Issue',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/journal/journal.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Journal',
     },
-    runGuardsAndResolvers: 'paramsChange',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Journal',
     },
-    runGuardsAndResolvers: 'paramsChange',
   },
 ];

overlord/src/app/ledger/ledger.component.ts

@@ -260,7 +260,13 @@ export class LedgerComponent {
 
   show() {
     const info = this.getInfo();
-    if (info.account) {
+    if (
+      this.id() === info.account?.id &&
+      this.startDate() === info.startDate &&
+      this.finishDate() === info.finishDate
+    ) {
+      this.infoResource.reload();
+    } else if (info.account) {
       this.router.navigate(['ledger', info.account.id], {
         queryParams: {
           startDate: info.startDate,

overlord/src/app/ledger/ledger.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/mozimo-daily-register/mozimo-daily-register.component.ts

@@ -111,8 +111,12 @@ export class MozimoDailyRegisterComponent {
 
   show() {
     const date = moment(this.model().date).format('DD-MMM-YYYY');
+    if (this.date() === date) {
+      this.infoResource.reload();
+    } else {
       this.router.navigate(['/mozimo-daily-register', date]);
     }
+  }
 
   save() {
     this.ser.save(this.getMozimoDailyRegister()).subscribe({

overlord/src/app/mozimo-daily-register/mozimo-daily-register.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Product Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':date',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Product Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/mozimo-product-register/mozimo-product-register.component.ts

@@ -136,6 +136,13 @@ export class MozimoProductRegisterComponent {
   show() {
     const info = this.getInfo();
     if (info.product) {
+      if (
+        this.id() === info.product.id &&
+        this.startDate() === info.startDate &&
+        this.finishDate() === info.finishDate
+      ) {
+        this.infoResource.reload();
+      } else {
         this.router.navigate(['mozimo-product-register', info.product.id], {
           queryParams: {
             startDate: info.startDate,
@@ -144,6 +151,7 @@ export class MozimoProductRegisterComponent {
         });
       }
     }
+  }
 
   save() {
     this.ser.save(this.getMozimoProductRegister()).subscribe({

overlord/src/app/mozimo-product-register/mozimo-product-register.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Product Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Product Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/net-transactions/net-transactions.component.ts

@@ -117,6 +117,9 @@ export class NetTransactionsComponent {
 
   show() {
     const l = this.prepareSubmit();
+    if (this.startDate() === l.startDate && this.finishDate() === l.finishDate) {
+      this.infoResource.reload();
+    } else {
       this.router.navigate(['net-transactions'], {
         queryParams: {
           startDate: l.startDate,
@@ -124,6 +127,7 @@ export class NetTransactionsComponent {
         },
       });
     }
+  }
 
   prepareSubmit(): NetTransactions {
     const formModel = this.model();

overlord/src/app/net-transactions/net-transactions.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'Net Transactions',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/non-contact-purchase/non-contract-purchase.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'Product Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/payment/payment.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'journal',
     },
-    runGuardsAndResolvers: 'paramsChange',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'journal',
     },
-    runGuardsAndResolvers: 'paramsChange',
   },
 ];

overlord/src/app/product-ledger/product-ledger.component.ts

@@ -211,6 +211,13 @@ export class ProductLedgerComponent {
   show() {
     const info = this.getInfo();
     if (info.product) {
+      if (
+        this.id() === info.product.id &&
+        this.startDate() === info.startDate &&
+        this.finishDate() === info.finishDate
+      ) {
+        this.infoResource.reload();
+      } else {
         this.router.navigate(['product-ledger', info.product.id], {
           queryParams: {
             startDate: info.startDate,
@@ -219,6 +226,7 @@ export class ProductLedgerComponent {
         });
       }
     }
+  }
 
   getInfo(): ProductLedger {
     const formModel = this.model();

overlord/src/app/product-ledger/product-ledger.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Product Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Product Ledger',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/profit-loss/profit-loss.component.ts

@@ -117,6 +117,9 @@ export class ProfitLossComponent {
 
   show() {
     const info = this.getInfo();
+    if (this.startDate() === info.startDate && this.finishDate() === info.finishDate) {
+      this.infoResource.reload();
+    } else {
       this.router.navigate(['profit-loss'], {
         queryParams: {
           startDate: info.startDate,
@@ -124,6 +127,7 @@ export class ProfitLossComponent {
         },
       });
     }
+  }
 
   getInfo(): ProfitLoss {
     const formModel = this.formModel();

overlord/src/app/profit-loss/profit-loss.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'Profit & Loss',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/purchase-entries/purchase-entries.component.ts

@@ -121,6 +121,9 @@ export class PurchaseEntriesComponent {
 
   show() {
     const l = this.prepareSubmit();
+    if (this.startDate() === l.startDate && this.finishDate() === l.finishDate) {
+      this.resource.reload();
+    } else {
       this.router.navigate(['purchase-entries'], {
         queryParams: {
           startDate: l.startDate,
@@ -128,6 +131,7 @@ export class PurchaseEntriesComponent {
         },
       });
     }
+  }
 
   prepareSubmit(): PurchaseEntries {
     const formModel = this.formModel();

overlord/src/app/purchase-entries/purchase-entries.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'Purchase Entries',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/purchase-return/purchase-return.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Purchase Return',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Purchase Return',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/purchase/purchase.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Purchase',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Purchase',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/purchases/purchases.component.ts

@@ -115,6 +115,9 @@ export class PurchasesComponent {
 
   show() {
     const l = this.prepareSubmit();
+    if (this.startDate() === l.startDate && this.finishDate() === l.finishDate) {
+      this.resource.reload();
+    } else {
       this.router.navigate(['purchases'], {
         queryParams: {
           startDate: l.startDate,
@@ -122,6 +125,7 @@ export class PurchasesComponent {
         },
       });
     }
+  }
 
   prepareSubmit(): Purchases {
     const formModel = this.formModel();

overlord/src/app/purchases/purchases.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'Purchases',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/raw-material-cost/raw-material-cost.component.ts

@@ -131,6 +131,9 @@ export class RawMaterialCostComponent {
 
   show() {
     const model = this.prepareSubmit();
+    if (!this.id() && this.startDate() === model.startDate && this.finishDate() === model.finishDate) {
+      this.infoResource.reload();
+    } else {
       this.router.navigate(['raw-material-cost'], {
         queryParams: {
           startDate: model.startDate,
@@ -138,6 +141,7 @@ export class RawMaterialCostComponent {
         },
       });
     }
+  }
 
   prepareSubmit(): RawMaterialCost {
     const formModel = this.formModel();

overlord/src/app/raw-material-cost/raw-material-cost.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Raw Material Cost',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Raw Material Cost',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/receipt/receipt.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'journal',
     },
-    runGuardsAndResolvers: 'paramsChange',
   },
   {
     path: ':id',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'journal',
     },
-    runGuardsAndResolvers: 'paramsChange',
   },
 ];

overlord/src/app/recipe/recipe.routes.ts

@@ -12,7 +12,6 @@ export const routes: Routes = [
     data: {
       permission: 'Recipes',
     },
-    runGuardsAndResolvers: 'paramsOrQueryParamsChange',
   },
   {
     path: 'new',

overlord/src/app/settings/settings.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'Maintenance', // 'Lock Date'
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/stock-movement/stock-movement.component.ts

@@ -114,6 +114,9 @@ export class StockMovementComponent {
 
   show() {
     const l = this.prepareSubmit();
+    if (this.startDate() === l.startDate && this.finishDate() === l.finishDate) {
+      this.resource.reload();
+    } else {
       this.router.navigate(['stock-movement'], {
         queryParams: {
           startDate: l.startDate,
@@ -121,6 +124,7 @@ export class StockMovementComponent {
         },
       });
     }
+  }
 
   prepareSubmit(): StockMovement {
     const formModel = this.formModel();

overlord/src/app/stock-movement/stock-movement.routes.ts

@@ -11,6 +11,5 @@ export const routes: Routes = [
     data: {
       permission: 'Stock Movement',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/app/trial-balance/trial-balance.component.ts

@@ -109,8 +109,12 @@ export class TrialBalanceComponent {
 
   show() {
     const info = this.getInfo();
+    if (this.date() === info.date) {
+      this.resource.reload();
+    } else {
       this.router.navigate(['trial-balance', info.date]);
     }
+  }
 
   getInfo(): TrialBalance {
     const formModel = this.formModel();

overlord/src/app/trial-balance/trial-balance.routes.ts

@@ -11,7 +11,6 @@ export const routes: Routes = [
     data: {
       permission: 'Trial Balance',
     },
-    runGuardsAndResolvers: 'always',
   },
   {
     path: ':date',
@@ -20,6 +19,5 @@ export const routes: Routes = [
     data: {
       permission: 'Trial Balance',
     },
-    runGuardsAndResolvers: 'always',
   },
 ];

overlord/src/styles.sass

@@ -32,12 +32,12 @@ a
   text-decoration: underline
 
 
-button.mat-primary 
+button.mat-primary:not(:disabled)
   background: var(--mat-sys-primary) !important
   color: var(--mat-sys-on-primary) !important
 
 
-button.mat-warn 
+button.mat-warn:not(:disabled)
   background: var(--mat-sys-error) !important
   color: var(--mat-sys-on-error) !important