tanshu/brewman
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Fix: The batch integrity report was not taking into account the closing stock entries and resetting stock to wrong levels. Fixed

Browse Source
This commit is contained in:
Amritanshu Agrawal 2021-12-26 06:57:37 +05:30
parent 9f2e28a035
commit 68390a1eb6
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
brewman/brewman/routers/batch_integrity.py
View File

@ -17,7 +17,6 @@ from ..models.journal import Journal
from ..models.product import Product from ..models.product import Product
from ..models.stock_keeping_unit import StockKeepingUnit from ..models.stock_keeping_unit import StockKeepingUnit
from ..models.voucher import Voucher from ..models.voucher import Voucher
from ..models.voucher_type import VoucherType
from ..schemas.user import UserToken from ..schemas.user import UserToken
from .issue import refresh_voucher from .issue import refresh_voucher
@ -47,14 +46,6 @@ def negative_batches(db: Session) -> List[schemas.BatchIntegrity]:
.join(Inventory.voucher) .join(Inventory.voucher)
.join(Voucher.journals) .join(Voucher.journals)
.where( .where(
Voucher.voucher_type.in_(
[
VoucherType.PURCHASE,
VoucherType.PURCHASE_RETURN,
VoucherType.ISSUE,
VoucherType.OPENING_BATCHES,
]
),
Journal.cost_centre_id == CostCentre.cost_centre_purchase(), Journal.cost_centre_id == CostCentre.cost_centre_purchase(),
) )
.group_by(Batch, Product.name) .group_by(Batch, Product.name)
@ -87,14 +78,6 @@ def batch_details(batch_id: uuid.UUID, db: Session) -> List[schemas.BatchIntegri
.join(Voucher.journals) .join(Voucher.journals)
.where( .where(
Inventory.batch_id == batch_id, Inventory.batch_id == batch_id,
Voucher.voucher_type.in_(
[
VoucherType.PURCHASE,
VoucherType.PURCHASE_RETURN,
VoucherType.ISSUE,
VoucherType.OPENING_BATCHES,
]
),
Journal.cost_centre_id == CostCentre.cost_centre_purchase(), Journal.cost_centre_id == CostCentre.cost_centre_purchase(),
) )
).all() ).all()