Fix: Login deleting old clients was conflicting with login history

Chore: Moved to angular linting using the recommended plugins / settings

overlord/src/app/closing-stock/closing-stock-datasource.ts

@@ -8,9 +8,7 @@ import { map } from 'rxjs/operators';
 import { ClosingStockItem } from './closing-stock-item';
 
 /** Simple sort comparator for example ID/Name columns (for client-side sorting). */
-function compare(a: string | number, b: string | number, isAsc: boolean) {
-  return (a < b ? -1 : 1) * (isAsc ? 1 : -1);
-}
+const compare = (a: string | number, b: string | number, isAsc: boolean) => (a < b ? -1 : 1) * (isAsc ? 1 : -1);
 export class ClosingStockDataSource extends DataSource<ClosingStockItem> {
   constructor(
     public data: ClosingStockItem[],
@@ -26,11 +24,17 @@ export class ClosingStockDataSource extends DataSource<ClosingStockItem> {
       | EventEmitter<PageEvent>
       | EventEmitter<Sort>
     )[] = [observableOf(this.data)];
-    if (this.paginator) dataMutations.push((this.paginator as MatPaginator).page);
-    if (this.sort) dataMutations.push((this.sort as MatSort).sortChange);
+    if (this.paginator) {
+      dataMutations.push((this.paginator as MatPaginator).page);
+    }
+    if (this.sort) {
+      dataMutations.push((this.sort as MatSort).sortChange);
+    }
 
     // Set the paginators length
-    if (this.paginator) this.paginator.length = this.data.length;
+    if (this.paginator) {
+      this.paginator.length = this.data.length;
+    }
 
     return merge(...dataMutations).pipe(
       map(() => this.getPagedData(this.getSortedData([...this.data]))),
@@ -40,13 +44,17 @@ export class ClosingStockDataSource extends DataSource<ClosingStockItem> {
   disconnect() {}
 
   private getPagedData(data: ClosingStockItem[]) {
-    if (this.paginator === undefined) return data;
+    if (this.paginator === undefined) {
+      return data;
+    }
     const startIndex = this.paginator.pageIndex * this.paginator.pageSize;
     return data.splice(startIndex, this.paginator.pageSize);
   }
 
   private getSortedData(data: ClosingStockItem[]) {
-    if (this.sort === undefined) return data;
+    if (this.sort === undefined) {
+      return data;
+    }
     if (!this.sort.active || this.sort.direction === '') {
       return data;
     }

overlord/src/app/closing-stock/closing-stock-resolver.service.spec.ts

@@ -1,5 +1,5 @@
-import { inject, TestBed } from '@angular/core/testing';
 import { HttpClientModule } from '@angular/common/http';
+import { inject, TestBed } from '@angular/core/testing';
 
 import { ClosingStockResolver } from './closing-stock-resolver.service';
 

overlord/src/app/closing-stock/closing-stock.service.spec.ts

@@ -1,5 +1,5 @@
-import { inject, TestBed } from '@angular/core/testing';
 import { HttpClientModule } from '@angular/common/http';
+import { inject, TestBed } from '@angular/core/testing';
 
 import { ClosingStockService } from './closing-stock.service';
 

overlord/src/app/closing-stock/closing-stock.service.ts

@@ -18,10 +18,8 @@ export class ClosingStockService {
 
   list(date: string | null): Observable<ClosingStock> {
     const listUrl = date === null ? url : `${url}/${date}`;
-    return <Observable<ClosingStock>>(
-      this.http
-        .get<ClosingStock>(listUrl)
-        .pipe(catchError(this.log.handleError(serviceName, 'list')))
-    );
+    return this.http
+      .get<ClosingStock>(listUrl)
+      .pipe(catchError(this.log.handleError(serviceName, 'list'))) as Observable<ClosingStock>;
   }
 }