Fix: Login deleting old clients was conflicting with login history

Chore: Moved to angular linting using the recommended plugins / settings

overlord/src/app/client/client-detail/client-detail.component.spec.ts

@@ -1,6 +1,6 @@
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { MatDialogModule } from '@angular/material/dialog';
 import { ReactiveFormsModule } from '@angular/forms';
+import { MatDialogModule } from '@angular/material/dialog';
 import { RouterTestingModule } from '@angular/router/testing';
 
 import { ClientDetailComponent } from './client-detail.component';

overlord/src/app/client/client-detail/client-detail.component.ts

@@ -54,7 +54,9 @@ export class ClientDetailComponent implements OnInit, AfterViewInit {
 
   ngAfterViewInit() {
     setTimeout(() => {
-      if (this.nameElement) this.nameElement.nativeElement.focus();
+      if (this.nameElement) {
+        this.nameElement.nativeElement.focus();
+      }
     }, 0);
   }
 

overlord/src/app/client/client-list-resolver.service.spec.ts

@@ -1,5 +1,5 @@
-import { inject, TestBed } from '@angular/core/testing';
 import { HttpClientModule } from '@angular/common/http';
+import { inject, TestBed } from '@angular/core/testing';
 import { RouterTestingModule } from '@angular/router/testing';
 
 import { ClientListResolver } from './client-list-resolver.service';

overlord/src/app/client/client-list/client-list-datasource.ts

@@ -8,9 +8,7 @@ import { map } from 'rxjs/operators';
 import { Client } from '../client';
 
 /** Simple sort comparator for example ID/Name columns (for client-side sorting). */
-function compare(a: string | number, b: string | number, isAsc: boolean) {
-  return (a < b ? -1 : 1) * (isAsc ? 1 : -1);
-}
+const compare = (a: string | number, b: string | number, isAsc: boolean) => (a < b ? -1 : 1) * (isAsc ? 1 : -1);
 export class ClientListDataSource extends DataSource<Client> {
   constructor(public data: Client[], private paginator?: MatPaginator, private sort?: MatSort) {
     super();
@@ -20,11 +18,17 @@ export class ClientListDataSource extends DataSource<Client> {
     const dataMutations: (Observable<Client[]> | EventEmitter<PageEvent> | EventEmitter<Sort>)[] = [
       observableOf(this.data),
     ];
-    if (this.paginator) dataMutations.push((this.paginator as MatPaginator).page);
-    if (this.sort) dataMutations.push((this.sort as MatSort).sortChange);
+    if (this.paginator) {
+      dataMutations.push((this.paginator as MatPaginator).page);
+    }
+    if (this.sort) {
+      dataMutations.push((this.sort as MatSort).sortChange);
+    }
 
     // Set the paginators length
-    if (this.paginator) this.paginator.length = this.data.length;
+    if (this.paginator) {
+      this.paginator.length = this.data.length;
+    }
 
     return merge(...dataMutations).pipe(
       map(() => this.getPagedData(this.getSortedData([...this.data]))),
@@ -34,13 +38,17 @@ export class ClientListDataSource extends DataSource<Client> {
   disconnect() {}
 
   private getPagedData(data: Client[]) {
-    if (this.paginator === undefined) return data;
+    if (this.paginator === undefined) {
+      return data;
+    }
     const startIndex = this.paginator.pageIndex * this.paginator.pageSize;
     return data.splice(startIndex, this.paginator.pageSize);
   }
 
   private getSortedData(data: Client[]) {
-    if (this.sort === undefined) return data;
+    if (this.sort === undefined) {
+      return data;
+    }
     if (!this.sort.active || this.sort.direction === '') {
       return data;
     }

overlord/src/app/client/client-resolver.service.spec.ts

@@ -1,5 +1,5 @@
-import { inject, TestBed } from '@angular/core/testing';
 import { HttpClientModule } from '@angular/common/http';
+import { inject, TestBed } from '@angular/core/testing';
 import { RouterTestingModule } from '@angular/router/testing';
 
 import { ClientResolver } from './client-resolver.service';

overlord/src/app/client/client.service.spec.ts

@@ -1,5 +1,5 @@
-import { inject, TestBed } from '@angular/core/testing';
 import { HttpClientModule } from '@angular/common/http';
+import { inject, TestBed } from '@angular/core/testing';
 
 import { ClientService } from './client.service';
 

overlord/src/app/client/client.service.ts

@@ -7,9 +7,6 @@ import { ErrorLoggerService } from '../core/error-logger.service';
 
 import { Client } from './client';
 
-const httpOptions = {
-  headers: new HttpHeaders({ 'Content-Type': 'application/json' }),
-};
 const url = '/api/clients';
 const serviceName = 'ClientService';
 
@@ -21,34 +18,26 @@ export class ClientService {
 
   get(id: string | null): Observable<Client> {
     const getUrl: string = id === null ? url : `${url}/${id}`;
-    return <Observable<Client>>(
-      this.http
-        .get<Client>(getUrl)
-        .pipe(catchError(this.log.handleError(serviceName, `get id=${id}`)))
-    );
+    return this.http
+      .get<Client>(getUrl)
+      .pipe(catchError(this.log.handleError(serviceName, `get id as Observable<Client>=${id}`))) as Observable<Client>;
   }
 
   list(): Observable<Client[]> {
-    return <Observable<Client[]>>(
-      this.http
-        .get<Client[]>(`${url}/list`)
-        .pipe(catchError(this.log.handleError(serviceName, 'list')))
-    );
+    return this.http
+      .get<Client[]>(`${url}/list`)
+      .pipe(catchError(this.log.handleError(serviceName, 'list'))) as Observable<Client[]>;
   }
 
   update(client: Client): Observable<Client> {
-    return <Observable<Client>>(
-      this.http
-        .put<Client>(`${url}/${client.id}`, client, httpOptions)
-        .pipe(catchError(this.log.handleError(serviceName, 'update')))
-    );
+    return this.http
+      .put<Client>(`${url}/${client.id}`, client)
+      .pipe(catchError(this.log.handleError(serviceName, 'update'))) as Observable<Client>;
   }
 
   delete(id: string): Observable<Client> {
-    return <Observable<Client>>(
-      this.http
-        .delete<Client>(`${url}/${id}`, httpOptions)
-        .pipe(catchError(this.log.handleError(serviceName, 'delete')))
-    );
+    return this.http
+      .delete<Client>(`${url}/${id}`)
+      .pipe(catchError(this.log.handleError(serviceName, 'delete'))) as Observable<Client>;
   }
 }