Chore: Check for deprecations using eslint plugin

Chore: environment file replacement stopped.
Chore: All components are now standalone and removed all modules
Chore: App routing is now in app.routes and similarly for all submodules
Chore: Http interceptors are now functional and split refresh interceptor into a separate one.

overlord/src/app/product/product-detail/product-detail-dialog.component.spec.ts

@@ -1,4 +1,4 @@
-import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
 
 import { ProductDetailDialogComponent } from './product-detail-dialog.component';
 
@@ -6,13 +6,11 @@ describe('ProductDetailDialogComponent', () => {
   let component: ProductDetailDialogComponent;
   let fixture: ComponentFixture<ProductDetailDialogComponent>;
 
-  beforeEach(waitForAsync(() => {
-    TestBed.configureTestingModule({
-      declarations: [ProductDetailDialogComponent],
+  beforeEach(async () => {
+    await TestBed.configureTestingModule({
+      imports: [ProductDetailDialogComponent],
     }).compileComponents();
-  }));
 
-  beforeEach(() => {
     fixture = TestBed.createComponent(ProductDetailDialogComponent);
     component = fixture.componentInstance;
     fixture.detectChanges();

overlord/src/app/product/product-detail/product-detail-dialog.component.ts

@@ -1,6 +1,17 @@
+import { CdkScrollable } from '@angular/cdk/scrolling';
 import { Component, Inject, OnInit } from '@angular/core';
-import { FormControl, FormGroup } from '@angular/forms';
-import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
+import { FormControl, FormGroup, ReactiveFormsModule } from '@angular/forms';
+import { MatButton } from '@angular/material/button';
+import {
+  MAT_DIALOG_DATA,
+  MatDialogRef,
+  MatDialogTitle,
+  MatDialogContent,
+  MatDialogActions,
+  MatDialogClose,
+} from '@angular/material/dialog';
+import { MatFormField, MatLabel } from '@angular/material/form-field';
+import { MatInput } from '@angular/material/input';
 
 import { StockKeepingUnit } from '../../core/product';
 
@@ -8,6 +19,19 @@ import { StockKeepingUnit } from '../../core/product';
   selector: 'app-journal-dialog',
   templateUrl: './product-detail-dialog.component.html',
   styleUrls: ['./product-detail-dialog.component.css'],
+  standalone: true,
+  imports: [
+    MatDialogTitle,
+    CdkScrollable,
+    MatDialogContent,
+    ReactiveFormsModule,
+    MatFormField,
+    MatLabel,
+    MatInput,
+    MatDialogActions,
+    MatButton,
+    MatDialogClose,
+  ],
 })
 export class ProductDetailDialogComponent implements OnInit {
   form: FormGroup<{

overlord/src/app/product/product-detail/product-detail.component.spec.ts

@@ -1,7 +1,4 @@
-import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { ReactiveFormsModule } from '@angular/forms';
-import { MatDialogModule } from '@angular/material/dialog';
-import { RouterTestingModule } from '@angular/router/testing';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
 
 import { ProductDetailComponent } from './product-detail.component';
 
@@ -9,14 +6,11 @@ describe('ProductDetailComponent', () => {
   let component: ProductDetailComponent;
   let fixture: ComponentFixture<ProductDetailComponent>;
 
-  beforeEach(waitForAsync(() => {
-    TestBed.configureTestingModule({
-      imports: [MatDialogModule, ReactiveFormsModule, RouterTestingModule],
-      declarations: [ProductDetailComponent],
+  beforeEach(async () => {
+    await TestBed.configureTestingModule({
+      imports: [ProductDetailComponent],
     }).compileComponents();
-  }));
 
-  beforeEach(() => {
     fixture = TestBed.createComponent(ProductDetailComponent);
     component = fixture.componentInstance;
     fixture.detectChanges();

overlord/src/app/product/product-detail/product-detail.component.ts

@@ -1,6 +1,27 @@
+import { CurrencyPipe } from '@angular/common';
 import { AfterViewInit, Component, ElementRef, OnInit, ViewChild } from '@angular/core';
-import { FormControl, FormGroup } from '@angular/forms';
+import { FormControl, FormGroup, ReactiveFormsModule } from '@angular/forms';
+import { MatButton, MatIconButton } from '@angular/material/button';
+import { MatCard, MatCardHeader, MatCardTitle, MatCardContent, MatCardActions } from '@angular/material/card';
+import { MatCheckbox } from '@angular/material/checkbox';
+import { MatOption } from '@angular/material/core';
 import { MatDialog } from '@angular/material/dialog';
+import { MatFormField, MatLabel } from '@angular/material/form-field';
+import { MatIcon } from '@angular/material/icon';
+import { MatInput } from '@angular/material/input';
+import { MatSelect } from '@angular/material/select';
+import {
+  MatTable,
+  MatColumnDef,
+  MatHeaderCellDef,
+  MatHeaderCell,
+  MatCellDef,
+  MatCell,
+  MatHeaderRowDef,
+  MatHeaderRow,
+  MatRowDef,
+  MatRow,
+} from '@angular/material/table';
 import { ActivatedRoute, Router } from '@angular/router';
 import { BehaviorSubject } from 'rxjs';
 
@@ -17,6 +38,35 @@ import { ProductDetailDialogComponent } from './product-detail-dialog.component'
   selector: 'app-product-detail',
   templateUrl: './product-detail.component.html',
   styleUrls: ['./product-detail.component.css'],
+  standalone: true,
+  imports: [
+    MatCard,
+    MatCardHeader,
+    MatCardTitle,
+    MatCardContent,
+    ReactiveFormsModule,
+    MatFormField,
+    MatLabel,
+    MatInput,
+    MatCheckbox,
+    MatSelect,
+    MatOption,
+    MatButton,
+    MatTable,
+    MatColumnDef,
+    MatHeaderCellDef,
+    MatHeaderCell,
+    MatCellDef,
+    MatCell,
+    MatIconButton,
+    MatIcon,
+    MatHeaderRowDef,
+    MatHeaderRow,
+    MatRowDef,
+    MatRow,
+    MatCardActions,
+    CurrencyPipe,
+  ],
 })
 export class ProductDetailComponent implements OnInit, AfterViewInit {
   @ViewChild('nameElement', { static: true }) nameElement?: ElementRef;
@@ -233,27 +283,27 @@ export class ProductDetailComponent implements OnInit, AfterViewInit {
   }
 
   save() {
-    this.ser.saveOrUpdate(this.getItem()).subscribe(
-      () => {
+    this.ser.saveOrUpdate(this.getItem()).subscribe({
+      next: () => {
         this.toaster.show('Success', '');
         this.router.navigateByUrl('/products');
       },
-      (error) => {
+      error: (error) => {
         this.toaster.show('Danger', error);
       },
-    );
+    });
   }
 
   delete() {
-    this.ser.delete(this.item.id as string).subscribe(
-      () => {
+    this.ser.delete(this.item.id as string).subscribe({
+      next: () => {
         this.toaster.show('Success', '');
         this.router.navigateByUrl('/products');
       },
-      (error) => {
+      error: (error) => {
         this.toaster.show('Danger', error);
       },
-    );
+    });
   }
 
   confirmDelete(): void {

overlord/src/app/product/product-list/product-list.component.spec.ts

@@ -1,6 +1,4 @@
 import { ComponentFixture, fakeAsync, TestBed } from '@angular/core/testing';
-import { ReactiveFormsModule } from '@angular/forms';
-import { RouterTestingModule } from '@angular/router/testing';
 
 import { ProductListComponent } from './product-list.component';
 
@@ -10,8 +8,7 @@ describe('ProductListComponent', () => {
 
   beforeEach(fakeAsync(() => {
     TestBed.configureTestingModule({
-      imports: [ReactiveFormsModule, RouterTestingModule],
-      declarations: [ProductListComponent],
+      imports: [ReactiveFormsModule, RouterTestingModule, ProductListComponent],
     }).compileComponents();
 
     fixture = TestBed.createComponent(ProductListComponent);

overlord/src/app/product/product-list/product-list.component.ts

@@ -1,8 +1,26 @@
+import { PercentPipe, CurrencyPipe } from '@angular/common';
 import { AfterViewInit, Component, ElementRef, OnInit, ViewChild } from '@angular/core';
-import { FormControl, FormGroup } from '@angular/forms';
+import { FormControl, FormGroup, ReactiveFormsModule } from '@angular/forms';
+import { MatIconButton, MatAnchor } from '@angular/material/button';
+import { MatCard, MatCardHeader, MatCardTitleGroup, MatCardTitle, MatCardContent } from '@angular/material/card';
+import { MatFormField, MatLabel } from '@angular/material/form-field';
+import { MatIcon } from '@angular/material/icon';
+import { MatInput } from '@angular/material/input';
 import { MatPaginator } from '@angular/material/paginator';
-import { MatSort } from '@angular/material/sort';
-import { ActivatedRoute } from '@angular/router';
+import { MatSort, MatSortHeader } from '@angular/material/sort';
+import {
+  MatTable,
+  MatColumnDef,
+  MatHeaderCellDef,
+  MatHeaderCell,
+  MatCellDef,
+  MatCell,
+  MatHeaderRowDef,
+  MatHeaderRow,
+  MatRowDef,
+  MatRow,
+} from '@angular/material/table';
+import { ActivatedRoute, RouterLink } from '@angular/router';
 import { Observable } from 'rxjs';
 import { debounceTime, distinctUntilChanged } from 'rxjs/operators';
 
@@ -15,6 +33,37 @@ import { ProductListDataSource } from './product-list-datasource';
   selector: 'app-product-list',
   templateUrl: './product-list.component.html',
   styleUrls: ['./product-list.component.css'],
+  standalone: true,
+  imports: [
+    MatCard,
+    MatCardHeader,
+    MatCardTitleGroup,
+    MatCardTitle,
+    MatIconButton,
+    MatIcon,
+    MatAnchor,
+    RouterLink,
+    MatCardContent,
+    ReactiveFormsModule,
+    MatFormField,
+    MatLabel,
+    MatInput,
+    MatTable,
+    MatSort,
+    MatColumnDef,
+    MatHeaderCellDef,
+    MatHeaderCell,
+    MatSortHeader,
+    MatCellDef,
+    MatCell,
+    MatHeaderRowDef,
+    MatHeaderRow,
+    MatRowDef,
+    MatRow,
+    MatPaginator,
+    PercentPipe,
+    CurrencyPipe,
+  ],
 })
 export class ProductListComponent implements OnInit, AfterViewInit {
   @ViewChild('filterElement', { static: true }) filterElement?: ElementRef;

overlord/src/app/product/product-routing.module.spec.ts

@@ -1,13 +0,0 @@
-import { ProductRoutingModule } from './product-routing.module';
-
-describe('ProductRoutingModule', () => {
-  let productRoutingModule: ProductRoutingModule;
-
-  beforeEach(() => {
-    productRoutingModule = new ProductRoutingModule();
-  });
-
-  it('should create an instance', () => {
-    expect(productRoutingModule).toBeTruthy();
-  });
-});

overlord/src/app/product/product.module.spec.ts

@@ -1,13 +0,0 @@
-import { ProductModule } from './product.module';
-
-describe('ProductModule', () => {
-  let productModule: ProductModule;
-
-  beforeEach(() => {
-    productModule = new ProductModule();
-  });
-
-  it('should create an instance', () => {
-    expect(productModule).toBeTruthy();
-  });
-});

overlord/src/app/product/product.module.ts

@@ -1,44 +0,0 @@
-import { CdkTableModule } from '@angular/cdk/table';
-import { CommonModule } from '@angular/common';
-import { NgModule } from '@angular/core';
-import { ReactiveFormsModule } from '@angular/forms';
-import { MatButtonModule } from '@angular/material/button';
-import { MatCardModule } from '@angular/material/card';
-import { MatCheckboxModule } from '@angular/material/checkbox';
-import { MatOptionModule } from '@angular/material/core';
-import { MatDialogModule } from '@angular/material/dialog';
-import { MatIconModule } from '@angular/material/icon';
-import { MatInputModule } from '@angular/material/input';
-import { MatPaginatorModule } from '@angular/material/paginator';
-import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
-import { MatSelectModule } from '@angular/material/select';
-import { MatSortModule } from '@angular/material/sort';
-import { MatTableModule } from '@angular/material/table';
-
-import { ProductDetailDialogComponent } from './product-detail/product-detail-dialog.component';
-import { ProductDetailComponent } from './product-detail/product-detail.component';
-import { ProductListComponent } from './product-list/product-list.component';
-import { ProductRoutingModule } from './product-routing.module';
-
-@NgModule({
-  imports: [
-    CommonModule,
-    CdkTableModule,
-    MatTableModule,
-    MatPaginatorModule,
-    MatSortModule,
-    MatCardModule,
-    MatProgressSpinnerModule,
-    MatInputModule,
-    MatButtonModule,
-    MatIconModule,
-    MatOptionModule,
-    MatSelectModule,
-    MatCheckboxModule,
-    ReactiveFormsModule,
-    ProductRoutingModule,
-    MatDialogModule,
-  ],
-  declarations: [ProductListComponent, ProductDetailComponent, ProductDetailDialogComponent],
-})
-export class ProductModule {}

overlord/src/app/product/product.routes.ts

@@ -1,6 +1,4 @@
-import { CommonModule } from '@angular/common';
-import { NgModule } from '@angular/core';
-import { RouterModule, Routes } from '@angular/router';
+import { Routes } from '@angular/router';
 
 import { authGuard } from '../auth/auth-guard.service';
 import { productGroupListResolver } from '../product-group/product-group-list.resolver';
@@ -10,7 +8,7 @@ import { ProductListComponent } from './product-list/product-list.component';
 import { productListResolver } from './product-list.resolver';
 import { productResolver } from './product.resolver';
 
-const productRoutes: Routes = [
+export const routes: Routes = [
   {
     path: '',
     component: ProductListComponent,
@@ -47,9 +45,3 @@ const productRoutes: Routes = [
     },
   },
 ];
-
-@NgModule({
-  imports: [CommonModule, RouterModule.forChild(productRoutes)],
-  exports: [RouterModule],
-})
-export class ProductRoutingModule {}